Summary:	ASTERISK-08494: [patch] RELEASE COMPLETE is sent in state ACTIVE - leaves the trunk busy
Reporter:	Johann Steinwendtner (steinwej)	Labels:
Date Opened:	2007-01-05 10:24:55.000-0600	Date Closed:	2007-01-22 16:32:18.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) bug8733-diff.txt ( 1) trace.txt
Description:	Zaptel pri E1 interface, configured as EuroISDN, is configured to Nortel Meridian 1. Pri calls are made via the manager interface: Important: the second call is not successfull (e.g. number not existant) Here in out case: 38009 is not available at the Nortel switch, hence remote switch disconnects the call with cause 1. Action: Originate Channel: Zap/6/8006 Application: Dial Data: Zap/9/38009 Async: true Problem description: First call is successfull and in state active, the second call gets disconnected. This disconnects the first call with the same cause with a RELEASE COMPLETE message which is not valid. Trace see in attached file. ****** ADDITIONAL INFORMATION ****** This patch solves this kind of problem when first call is in state ACTIVE. Index: q931.c =================================================================== --- q931.c      (Revision 388) +++ q931.c      (Arbeitskopie) @@ -2931,8 +2931,10 @@                cause = c->cause;        if (cause == 34 || cause == 44 || cause == 82 || cause == 1 || cause == 81) {                /* We'll send RELEASE_COMPLETE with these causes */ -               disconnect = 0; -               release_compl = 1; +               if (c->ourcallstate != Q931_CALL_STATE_ACTIVE) { //ph +                       disconnect = 0; +                       release_compl = 1; +               }        }        if (cause == 6 || cause == 7 || cause == 26) {                /* We'll send RELEASE with these causes */
Comments:	By: Serge Vecher (serge-v) 2007-01-05 10:40:36.000-0600 1. Could you please get a disclaimer on file (see bottom of http://bugs.digium.com/main_page.php) and confirm with a note here when done? 2. It would be great if you could upload your change as a patch-file. See  http://www.asterisk.org/developers/Patch_Howto By: Johann Steinwendtner (steinwej) 2007-01-08 07:55:14.000-0600 Do I really need a diclaimer filed for a one-liner patch ? I've seen other bug reports where it was not necessary. By: Matthew Fredrickson (mattf) 2007-01-22 16:31:50.000-0600 You're right, I see the bug.  It should be fixed now in 1.2, 1.4, and trunk.