[Home]

Summary:ASTERISK-08441: [patch] coding guidelines compliance for main/*.c
Reporter:Jon Creasy (johann8384)Labels:
Date Opened:2006-12-27 12:55:59.000-0600Date Closed:2007-01-22 18:12:51.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) coding_guidelines_whitespace.patch
( 1) coding_guidelines.patch
( 2) manual_coding_guidelines.patch
Description:After it was mentioned in regards to another patch about the patch not meeting coding guidelines I updated the entire rtp.c file based on the information provided on the developer pages.



****** ADDITIONAL INFORMATION ******

Command used:

indent -i4 -ts4 -br -brs -cdw -lp -ce -nbfda -npcs -nprs -npsl -nbbo -saf -sai -saw -cs -l90 main/rtp.c

As directed by:

http://www.asterisk.org/developers/coding-guidelines
Comments:By: Jon Creasy (johann8384) 2006-12-27 13:05:29.000-0600

It looks like that command did some things that aren't quite like the examples farther down in the file. I'll have to go back over the patch and fix those things.

main/rtp.c :

/*!
* \brief Structure representing a RTP session.
*
* RTP session is defined on page 9 of RFC 3550: "An association among a set of participants communicating with RTP.  A participant may be involved in multip$
*
*/
/*! \brief The value of each payload format mapping: */
        struct rtpPayloadType {
                int isAstFormat;               /*!< whether the following code is an AST_FORMAT */
                int code;
        };

The example:

/*!
* \brief A very interesting structure.
*/
struct interesting_struct
{
/*! \brief A data member. */
int member1;

int member2; /*!
By: Anthony LaMantia (alamantia) 2006-12-27 13:33:28.000-0600

assigned to file for commital, i reviewed most of the patch here and it seem to be   allright.
By: Jon Creasy (johann8384) 2006-12-27 13:49:18.000-0600

I went and did some changes to the rest of the files in main.
By: Joshua C. Colp (jcolp) 2007-01-22 18:12:51.000-0600

Put into trunk as of revisions 51463 and 51486 with mods. Thanks!