Summary:ASTERISK-08358: [patch] Wrong Coding of Name in 'To:' header of Emails
Reporter:deti (deti)Labels:
Date Opened:2006-12-15 04:24:50.000-0600Date Closed:2007-01-09 07:45:36.000-0600
Versions:Frequency of
Environment:Attachments:( 0) 20070107__bug8595__quote_email.diff.txt
( 1) app_voicemail.c_bug8595.diff.txt
( 2) app_voicemail-1.2.c.fix.patch
( 3) app_voicemail-1.4.c.patch
Description:There is a problem when creating the 'To:'-header in emails: app_voicemail does:

To: Foo Bar <foo.bar@mail.com>

This works accidently when no coma in being used to seperate first and family name. When using a scheme like

To: Bar, Foo <foo.bar@mail.com>

sendmail will create two emails: one that goes to bar@localhost and another to foo.bar@mail.com.

Solution quote the name:

To: "Bar, Foo" <foo.bar@mail.com>

Comments:By: deti (deti) 2006-12-15 04:26:39.000-0600

Same problem applies to version 1.2 (see patch attached) - without opening a new ticket.

By: deti (deti) 2006-12-15 04:34:03.000-0600

Sorry but my app_voicemail-1.2.c.patch includes more than just a patch to app_voicemail.c.
As I could not delete the file from mantis please ignore patches to the other files.

By: Serge Vecher (serge-v) 2006-12-15 08:10:03.000-0600

deti: just reupload the 1.2 patch, if you will ...

By: Tilghman Lesher (tilghman) 2006-12-15 11:43:28.000-0600

These patches are not quite ready.  If you are going to insist that names be quoted, then any existing quotes already within the name must be escaped in some fashion.

By: deti (deti) 2006-12-15 12:01:55.000-0600

The patch fixes obvious problems first and it works for me actually. If there is for some reason someone out there who makes use of unbalanced quotes or invalid characters we'll still run into problems. Anyway I would like to see this patch applied to the repositories if nobody else feels responsible in delivering a better patch :)

By: Tilghman Lesher (tilghman) 2007-01-07 10:02:34.000-0600

New patch delivered (for 1.2)

By: deti (deti) 2007-01-08 11:33:28.000-0600

Patch 20070107__bug8595__quote_email.diff.txt does not work as the quote function appends a quote behind the end of the destination string. Fixed this in app_voicemail.c_bug8595.diff.txt which is against svn trunk 1.4
A backport against svn trunk 1.2 should be easy.

By: Tilghman Lesher (tilghman) 2007-01-09 07:45:35.000-0600

Fixed in 50150.  Merged to 1.4 in 50151.  Merged to trunk in 50152.