[Home]

Summary:ASTERISK-08357: [patch] make field names configurable in cdr_addon_mysql
Reporter:Afshin Mashayekhi (afshin)Labels:
Date Opened:2006-12-14 19:17:56.000-0600Date Closed:2007-06-08 10:25:00
Priority:MajorRegression?No
Status:Closed/CompleteComponents:CDR/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) cdr_addon_mysql.patch
( 1) cdr_addon_mysql.patch2
Description:I had this problem because I would like to have my own cdr table. I asked one of my friends and he fixed this problem for me. I attached the new c file. I test it and it's fine.
Comments:By: Russell Bryant (russell) 2006-12-14 20:24:59.000-0600

1) Proposed code additions need to be attached in svn diff format.

http://www.asterisk.org/developers/Patch_Howto

2) Before we can review any code submissions, the person who wrote the code must have a disclaimer on file with Digium.  Links to the two options for a disclaimer are available on the main page of bugs.digium.com.  The form will need to be faxed or mailed to Digium before we can consider this code.

By: Serge Vecher (serge-v) 2006-12-15 08:01:58.000-0600

1. Could you please get a disclaimer on file (see bottom of http://bugs.digium.com/main_page.php) and cofirm with a note here when done?
2. It would be great if you could upload your change as a patchfile. See  http://www.asterisk.org/developers/Patch_Howto

By: Afshin Mashayekhi (afshin) 2006-12-19 01:34:12.000-0600

I checked the configurable fields and there was no problem.

By: Serge Vecher (serge-v) 2006-12-19 11:18:54.000-0600

afshin: thanks for the patch. Can you please confirm your disclaimer status?

By: Afshin Mashayekhi (afshin) 2006-12-19 15:51:13.000-0600

serge-v: I couldn't find how to confirm my disclaimer. I faxed the disclaimer with my signature to Digium. isn't it enough?
Please let me know what should i do.

By: Serge Vecher (serge-v) 2006-12-19 16:28:51.000-0600

afshin: that's the confirmation I was looking for, thanks ;)

By: Russell Bryant (russell) 2006-12-19 19:46:44.000-0600

As I said in my first note, since your friend wrote the code, it is the friend that needs to sign the disclaimer.

By: Afshin Mashayekhi (afshin) 2006-12-27 18:28:34.000-0600

My friend (Bradley Latus) faxed the disclaimer for you... I hope you received it and apply the code to the SVN.

By: Afshin Mashayekhi (afshin) 2007-01-11 17:37:46.000-0600

there was something wrong in default field names in previous patch then please use the patch2 instead...
thank you

By: Clod Patry (junky) 2007-01-12 15:31:57.000-0600

maybe adding a diff for the sample will be useful.
Russell: is it a go for that concept?
If yes, I will write the patch for other cdr types.



By: Afshin Mashayekhi (afshin) 2007-01-12 17:31:07.000-0600

I don't understand what do you mean of sample... But if you mean the config file, here you are:
calldate_field=calldate
clid_field=clid
src_field=src
dst_field=dst
dcontext_field=dcontext
channel_field=channel
dstchannel_field=dstchannel
lastapp_field=lastapp
lastdata_field=lastdata
duration_field=duration
billsec_field=billsec
disposition_field=disposition
amaflags_field=amaflags
accountcode_field=accountcode
userfield_field=userfield
uniqueid_field=uniqueid

By: Russell Bryant (russell) 2007-06-08 10:24:59

This functionality has been merged into trunk in revision 391 with a patch from bbryant, based on the original patch posted here.  Thanks!