[Home]

Summary:ASTERISK-08346: [patch] Update to use the new ast_channel_alloc format
Reporter:dea (dea)Labels:
Date Opened:2006-12-13 11:53:53.000-0600Date Closed:2007-01-22 08:43:47.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_ooh323_channel_alloc.diff
( 1) chan_ooh323_channel_alloc-v2.diff
Description:SVN rev 47303 alters the ast_channel_alloc function.  The trivial patch attached updates -addons SVN 299 to use correct parameters.
Comments:By: Joshua C. Colp (jcolp) 2006-12-14 16:22:32.000-0600

Fixed in 1.4 as of revision 319 and trunk as of revision 320. Thanks!

By: dea (dea) 2006-12-14 19:06:25.000-0600

Re-opening to attach a follow-on patch to complete the fix.

By: Objective Systems (objsys) 2007-01-19 14:34:13.000-0600

Can you point where, ast_channel_alloc() function is setting the ch->cid.cid_name, ch->cid.cid_num or stat.

Else chan_ooh323_channel_alloc-v2.diff can't be applied.

I have checked other driver for reference, they are still setting ch->cid.cid_name, ch->cid.cid_number and passing parameters in ast_channel_alloc() function.

Regards,
Avin Patel

By: dea (dea) 2007-01-19 16:24:40.000-0600

Correct, drop the section of the patch that removes the code
for ch->cid.cid_name and ch->cid.cid_number.

I mis-read the new ast_channel_alloc().

The patch supplied works other than that.

By: Objective Systems (objsys) 2007-01-22 08:43:47.000-0600

First diff log already applied.
Second diff log can't be applied, as explained in messages.