| Summary: | ASTERISK-08318: [patch] introduce distinction between overlap-dial in sending/receiving mode | ||
| Reporter: | Stefano Brandimarte (stevens) | Labels: | |
| Date Opened: | 2006-12-10 10:30:46.000-0600 | Date Closed: | 2009-06-23 20:44:45 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_zap |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) chan_zap+overlaprecv.diff ( 1) chan_zap+overlaprecv-1.2.13.diff | |
| Description: | This is a patch to distinguish overlapdial in sending and in receiving mode. It allows to set "overlapdial" to "incoming", "outgoing", "both" or simply "yes" or "no" (default behaviour). So if we need just to overlap for incoming calls we set to 0 the "struct pri"->overlapdial int but let's use 2 as value for "struct zt_pri"->overlapdial. So we can place calls more quickly ("Sending Complete" is explicitly set in the SETUP message, instead of waiting for the other side timeout) and at the same time allow us to receive CALLINGSUBADDRs in overlap "receive only" mode. Please, note that the default behaviour isn't altered by this patch. We're using this patch and it works for us. Patch updated for asterisk 1.2.13 . ****** STEPS TO REPRODUCE ****** standard asterisk behaviour is to allow the user to set overlapdial to "yes" or "no"; if true (yes) overlapdial is enabled for both direction (sending/receiving) and if false (no) it's turned off (default configuration value) in both direction. ****** ADDITIONAL INFORMATION ****** Originally I uploaded this patch to help solving the bug ASTERISK-7316 http://bugs.digium.com/view.php?id=7511 (a bug that, actually, still exists) but even if it's only a work-around that problem, the need to distinguish between the two overlapping mode is addressed by this code. I've adopted the suggestion as in comment ASTERISK-5018535 for ASTERISK-7316 and introduced four defines to help reading the code. In addition I've to say that the static struct zt_pvt contains a completely unused (and potentially confusing) flag definition: unsigned int overlapdial:1; should it be leaved in place or (better) removed? | ||
| Comments: | By: hamed (hamy) 2006-12-18 12:49:25.000-0600 Is it possible to update the patch for 1.2.14? Thank you in advance By: Serge Vecher (serge-v) 2006-12-18 13:20:18.000-0600 oh, I almost forgot, since this is a new feature, the patch needs to be against trunk, unless the maintainers of the release branch decide that the feature fixes enough bugs to overrule the requirement. Usually, this is achieved by positive test reports with supporting evidence [hint, hint]. By: Stefano Brandimarte (stevens) 2006-12-18 20:58:58.000-0600 hamy, the above patch applies cleanly to 1.2.14 also; tried right now. By: Stefano Brandimarte (stevens) 2006-12-18 21:21:07.000-0600 serge-v, patch for SVN-48570M uploaded. By: hamed (hamy) 2006-12-19 18:33:29.000-0600 Thank you. By: Serge Vecher (serge-v) 2007-02-26 12:25:39.000-0600 hi, if you've tried the patch, can you please report your results? By: hamed (hamy) 2007-02-26 14:54:33.000-0600 I have. And it works like a charm. Euro-ISDN incoming overlap works fine applying this patch. By: Serge Vecher (serge-v) 2007-02-26 15:03:38.000-0600 mattf: I think this is ready for you. By: Matthew Fredrickson (mattf) 2007-06-06 18:12:56 Added to trunk. Sorry for the delay, thanks for your hard work. | ||