[Home]

Summary:ASTERISK-08171: probably useless code in handle_response_register()
Reporter:Luigi Rizzo (rizzo)Labels:
Date Opened:2006-11-22 07:32:27.000-0600Date Closed:2007-01-12 22:56:42.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/Registration
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:in multiple places, in handle_response_register(), there is the sequence

 12389                 if (global_regattempts_max)
 12390                         r->regattempts = global_regattempts_max+1;

meant to block further timeouts from being scheduled.
However this seems pointless since it is done when there is no pending timeout
anymore for that sip_registry structure, so nothing else will happen for
the entry.

I suggest to remove these lines.
Comments:By: Joshua C. Colp (jcolp) 2007-01-12 22:56:41.000-0600

Done in trunk as of revision 50709 with a few other mods.