Summary:ASTERISK-08150: [patch] Remove unused code from manager.c
Reporter:Andrey S Pankov (casper)Labels:
Date Opened:2006-11-18 13:08:18.000-0600Date Closed:2006-11-27 11:20:04.000-0600
Versions:Frequency of
Environment:Attachments:( 0) manager.c.diff
Description:s->dead and s->busy are no longer used in the code...
Comments:By: Joshua C. Colp (jcolp) 2006-11-20 21:01:02.000-0600

1.4 is in a state where we are only doing bug fixes, clean ups should occur in trunk and in trunk this stuff isn't applicable. Thank you none the less.

By: Andrey S Pankov (casper) 2006-11-22 23:13:21.000-0600

Let me explain the issue in more details then... For me this is rather a performance issue and thus could be considered as a bugfix.

First two chunks are pure cleanups - that's sure.

But the 3rd chunk is in process_events function called _very_ frequently when AMI is used (not that 's->busy--;' is a very CPU expensive operation, but please consider the amount of events generated for a single call at least for example).

The 4th chunk is in process_message function and removes two expensive operations - mutex lock/unlock.

The 5th chunk is in get_input function polling infinitely, but being interrupted with SIGURG at least from manager_event. Do we need an extra very unexpensive operation here after a context switching?

By: Russell Bryant (russell) 2006-11-27 11:20:04.000-0600

added to 1.4 in revision 48046, thanks