Summary:ASTERISK-08135: [patch] Asterisk 1.2 Built in transfer works different from version 1.0
Reporter:Xue Liangliang (xueliangliang)Labels:
Date Opened:2006-11-14 20:50:39.000-0600Date Closed:2007-07-09 21:20:43
Versions:Frequency of
Environment:Attachments:( 0) app.c.patch
Description:We use options 't' and 'T' in dial command to enable using asterisk
feature to do blind transfer, in 1.0, after you dial the number and
followed by a '#' key, asterisk will do the transfer immediately,
however in 1.2, after entering number and a # key, asterisk will wait
until digtit time out, then start to do the transfer, and last # key
was received by asterisk as part of the extension.


Check through the code, found a function 'ast_app_dtget' in app.c's logic flow has some problem. The attachment is the patch.
Comments:By: Jason Parker (jparker) 2006-11-16 14:16:29.000-0600

What happens when you have the extension "1234#"?  This would break that, would it not?

By: Xue Liangliang (xueliangliang) 2006-11-16 19:35:03.000-0600

I just make the migration smoother, and we don't have this kind of extension, if you use application Read() to get a extension then dial, this '1234#' will also break. In asterisk a lot of applications use '#' as the end of input, I feel all should have consistent behavior.

By: Russell Bryant (russell) 2007-04-03 11:26:56

Do you have a disclaimer on file?  If not, would you mind sending one in?  I can't look at your patch, otherwise.

By: Russell Bryant (russell) 2007-04-03 11:32:01

Actually, this probably isn't big enough to require it.  Feel free to submit one if you would like, though.

By: Russell Bryant (russell) 2007-04-03 13:15:56

This has been fixed in the 1.2 branch, 1.4 branch, and trunk in revisions 59886, 59887, and 59888.  Thanks!