Summary:ASTERISK-08103: possible memory leak in __sip_ack()
Reporter:Luigi Rizzo (rizzo)Labels:
Date Opened:2006-11-10 02:58:32.000-0600Date Closed:2006-11-10 07:12:08.000-0600
Versions:Frequency of
Description:__sip_ack(), when called by handle_response()
with resp == 491, does not free the packet, but because
the packet is not linked in the list anymore, the memory is leaked.

i am pretty much convinced that this is a true bug, no idea if
the different behaviour with resp==491 is because of some old
code that got deleted, or something else.
applies to svn, 1.4 and possibly more. not checked when it was introduced,
no idea how easy it is to trigger the problem.
Comments:By: Olle Johansson (oej) 2006-11-10 06:34:05.000-0600

Ahh. THe delayed retransmit stuff. Thanks for reminding me.

By: Olle Johansson (oej) 2006-11-10 06:35:00.000-0600

The idea was not to delete it, but to restart all retransmits a while later. So the packet should be deleted after the second transmit.

By: Olle Johansson (oej) 2006-11-10 06:47:13.000-0600

Decided to rip out this half-coded support for 491 and postpone proper implementation of it to next release. For now, we treat this as congestion.

By: Olle Johansson (oej) 2006-11-10 07:05:00.000-0600

Fix committed to 1.4 and trunk.

By: Olle Johansson (oej) 2006-11-10 07:12:08.000-0600

Fix to 1.4 rev 47418 and trunk. Thanks.