|Summary:||ASTERISK-08095: [patch] Refactoring of expression checking implementation|
|Reporter:||Markus Elfring (elfring)||Labels:|
|Date Opened:||2006-11-09 09:15:06.000-0600||Date Closed:||2007-01-24 12:48:41.000-0600|
|Environment:||Attachments:||( 0) check_expr2.diff|
( 1) check_expr3.diff
|Description:||I have looked at the function "check_expr" in the source file "check_expr.c". I have found some details that can be improved in its design.|
1. The input characters were compared to special values more often than it was required.
2. The buffer that was used to construct a warning message was too big.
Would you like to integrate the appended changes?
|Comments:||By: Russell Bryant (russell) 2006-11-09 09:53:35.000-0600|
You still need to file a disclaimer before anyone can review any of your patches. See the main page of bugs.digium.com to links to the disclaimer, as well as where to fax the form. Thanks!
By: Markus Elfring (elfring) 2006-11-18 14:25:37.000-0600
Did my letter arrive that I sent on Monday?
By: Anthony LaMantia (alamantia) 2006-11-28 10:37:40.000-0600
yes, it is on file now.
By: Steve Murphy (murf) 2007-01-24 12:48:41.000-0600
Many thanks, elfring! I spruced things up and made sure things actually compiled under 1.2, 1.4 and trunk, both in dev-mode and out of dev-mode.
see 1.2, r.52002
and trunk, r.52053