[Home]

Summary:ASTERISK-08088: Restore autoframing option
Reporter:dea (dea)Labels:
Date Opened:2006-11-08 15:33:09.000-0600Date Closed:2006-11-12 10:13:29.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/CodecHandling
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_sip-autoframing-fix.diff
Description:Auto-Framing is a process by which Asterisk will honor the
ptime: setting in the SDP.  This feature was included in the
RTP packetization patch, but had issues as described below.
The feature was accidentily partially supressed in process_sdp()
due to the checks for unsupported SDP.

If debugging was not set, the code would work, but setting any
level of debug to validate the code would shortcut the proccessing
of the SDP.

****** ADDITIONAL INFORMATION ******

This feature defaults to off.

If enabled Asterisk will set the RTP packetization to
the size requested by the endpoint, creating symmetric
RTP packetization payloads.

This patch does the following:
- Removes the 'unsupported' check for ptime: with debugging set
- Allows peers/users to inherit and override the global autoframing option
 -The original code gave undue priority to the global setting
  If the global option and user/peer options were set to the same
  value, it worked as expected, but if one was yes and the other
  was no, then the results would not be what the administrator
  intended

- Adds Auto-Framing status display to:
  sip show settings
  sip show peer xxxx
  sip show user xxxx
Comments:By: Olle Johansson (oej) 2006-11-10 07:23:42.000-0600

Formal stuff:

+ ast_log(LOG_DEBUG, "Auto-Faming set \n");

Miss-spelled, don't log to DEBUG without option_debug set

Otherwise: Where do you parse the ptime option?
By: dea (dea) 2006-11-10 11:27:15.000-0600

That line can be dropped, it was part of instrumenting the code to
see what was happening.  The ptime: option is parsed in process_sdp()
just below the test for sendrecv
By: Olle Johansson (oej) 2006-11-12 10:12:57.000-0600

Committed to svn 1.4 and trunk. 1.4 rev 47513, trunk rev 47514. Thank you for your contribution, DEA!