Summary:ASTERISK-08078: break instead of continue in get_sip_pvt_byid_locked()
Reporter:Luigi Rizzo (rizzo)Labels:
Date Opened:2006-11-07 10:10:11.000-0600Date Closed:2006-11-08 01:26:20.000-0600
Versions:Frequency of
Environment:Attachments:( 0) byid.diff
Description:on a tag mismatch, get_sip_pvt_byid_locked() should continue rather
than breaking out of the loop with the pvt unlocked.
patch attached - it affects all versions since this code was introduced
(20704 or so) but only if you enable pedanticsipchecking.
Comments:By: Olle Johansson (oej) 2006-11-07 11:27:03.000-0600

I don't see it in 1.2 - can you specify. The function looks very different there.
Fixed in 1.4. Thanks!

By: Luigi Rizzo (rizzo) 2006-11-07 11:37:16.000-0600

right - doesn't seem to be in 1.2.
this is where the function was introduced in trunk,
no idea if it should be in 1.2 as well.
but i'd consider the issue closed.

By: Olle Johansson (oej) 2006-11-08 01:26:19.000-0600

rizzo, you have bug marshal rights - you can close yourself instead of asking others...