| Summary: | ASTERISK-08061: [patch] INVITE w/Replaces - Replaces: header incorrectly uri encoded | ||
| Reporter: | John Riordan (john) | Labels: | |
| Date Opened: | 2006-11-03 13:15:40.000-0600 | Date Closed: | 2006-11-04 12:32:20.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) patch-chan_sip-refer.diff | |
| Description: | Issue: uri encoding is what we want to do if we are dealing with a uri. Here we storing the callid, to-tag, and from-tag in a string to be used in INVITE Replace: header during the attended transfer we are participating in. Encoding this value causes SIP transfers not to work properly. Patch: Don't uri encode the string as it is not a uri. Also, a copy of other minor fixes to handle_request_refer() | ||
| Comments: | By: Olle Johansson (oej) 2006-11-04 12:29:25.000-0600 Thank you for your feedback. I don't really agree with removing the fake ringing, since it's a usability issue with many phones and due to the bridging we have now, we don't know really. Regardless, even with the fake, it's a huge improvement over the bad code in 1.2. I've committed most of your changes. Thank you for your debugging! By: Olle Johansson (oej) 2006-11-04 12:30:32.000-0600 In the future, please separate the bug fix from other fixes so we can take one fix at a time. By: Olle Johansson (oej) 2006-11-04 12:32:20.000-0600 Committed with small change to 1.4 (rev 47199) and svn trunk. Thank you for contributing to Asterisk! | ||