| Summary: | ASTERISK-08020: [patch] rename app_cdr to app_nocdr, update copyright and doxygen info | ||
| Reporter: | Kenneth Shumard (kshumard) | Labels: | |
| Date Opened: | 2006-10-27 13:51:02 | Date Closed: | 2006-10-31 00:40:04.000-0600 |
| Priority: | Trivial | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_cdr |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) nocdr.patch | |
| Description: | I'm not certain it's appropriate to change Martin Pycko's email for Mark's under the header copyright info, but I think that has been done in most other asterisk source files. app_cdr claims that it implements "Applications connected with CDR engine", but all it does is implement NoCDR and nothing else. Renaming it and changing its brief description clarifies this. I don't know the appropriate diff/patch format to rename the file from app_cdr.c to app_nocdr.c, but that's a part of what I propose here. | ||
| Comments: | By: Russell Bryant (russell) 2006-10-31 00:40:04.000-0600 I added the "author" doxygen tag, but I left the rest out. If we ever want to add another CDR application, it should go in this file. Historically, there were more applications that lived here. Another thing to consider is that if anyone has "noload => app_cdr.so" in their configuration, it wouldn't work after this change. I just don't think it's worth it. :) Also, I don't see a need to change the email address, either. Anyway, thanks! | ||