Summary:ASTERISK-08016: [patch] "list" considered harmful
Reporter:Tilghman Lesher (tilghman)Labels:
Date Opened:2006-10-26 12:36:12Date Closed:2006-11-10 10:52:40.000-0600
Versions:Frequency of
Environment:Attachments:( 0) 20061026__list_considered_harmful__2.diff.txt
( 1) 20061110__bug8236_reversals.diff.txt
Description:It seems that the community in total disagrees with the change of commands from "show" to "list".  This patch reverts that change in 1.4.

It also makes the commands a little more consistent with the stated intent of "category verb argument".
Comments:By: Olle Johansson (oej) 2006-10-26 13:00:58

This is much better than the current syntax. I've suggested some small changes to Corydon-w on the IRC, but regardless - this is a huge improvement. I recommend committing it!

By: Olle Johansson (oej) 2006-10-26 13:05:12

We need to consider commands that are used a lot - like "set debug/verbose" and "extensions reload" - hiding them deep down might be bad from a usability standpoint.

I suggest that the "dialplan" category stays.
The "keys" category can move to under "iax2" - where they are used today.

By: Andrew D Kirch (trelane) 2006-10-26 15:13:24

I second OEJ's opinion, though I come from cisco and prefer "verb category argument" show is preferable to list, and the cleanups look to make the CLI significantly easier, commit.

By: BJ Weschke (bweschke) 2006-10-26 16:26:39


By: Michiel van Baak (mvanbaak) 2006-10-26 16:52:18

Please commit.
Thnx Corydon

By: Niklas Larsson (pnlarsson) 2006-10-27 01:06:23

Like this a lot

By: apollon (apollon) 2006-10-27 05:59:50


By: Tilghman Lesher (tilghman) 2006-11-02 17:02:28.000-0600

Committed, revision 47051.

By: Jason Parker (jparker) 2006-11-02 19:49:38.000-0600

I don't agree with much of this patch.

There are new inconsistancies introduced ("skinny no debug" vs "sip debug off").

Why did "module" go away?

By: Olle Johansson (oej) 2006-11-03 01:32:26.000-0600

Sneaking in deprecation of "sip reload" is considered harmful... We agreed earlier to keep all of those. I want to revert that part. I don't see why someone who manages Asterisk should have to know the names of the binary modules, that is far away from user friendly. Then we could simply change category to module, like
"chan_sip.so show peers"

That change was not part of this.

By: Tilghman Lesher (tilghman) 2006-11-03 09:24:52.000-0600

Qwell: Skinny has already been changed to "skinny debug off".  As far as the "module" prefix is concerned, oej's prior comment about hiding frequently used commands in the second bugnote stands -- hiding frequently used commands is bad from a usability standpoint.  However, for consistencies sake, I will upload a patch moving us back to using "module", since that is consistent with "category verb argument".

oej:  On the deprecation of 'sip reload' and 'iax2 reload', the real concern is that we have two different ways of doing a reload for certain modules, the canonical way (reload chan_sip.so) and the way for just a few modules (sip reload).  For consistencies sake, we ought to consider making the canonical method the standard way, even if we never remove 'sip reload'.

By: Tilghman Lesher (tilghman) 2006-11-03 15:09:23.000-0600

Okay, patch uploaded for comment.

By: Olle Johansson (oej) 2006-11-04 10:49:32.000-0600

Let's move "sip reload" out of this patch, since that was not changed by the verbalization re-organization.

By: Tilghman Lesher (tilghman) 2006-11-04 17:01:51.000-0600

oej:  In fact, that is exactly what the last patch does.

By: Jason Parker (jparker) 2006-11-07 13:09:55.000-0600

Some of the arguments appear to be "off" in the proposed patch.  These need to be very carefully looked at.

For instance, the code from "sip set debug ip" has the following, for checking for the arg "ip"

else if (strcmp(argv[2], "ip") == 0)

I'm pretty sure it should be argv[3]

By: Tilghman Lesher (tilghman) 2006-11-09 14:47:52.000-0600

Patch revised.

By: Tilghman Lesher (tilghman) 2006-11-10 10:52:40.000-0600

Committed in 47436.