[Home]

Summary:ASTERISK-07989: [patch] outside user can't get auth for subscribtion when adding asterisk's account to their IM
Reporter:caspy (caspy)Labels:
Date Opened:2006-10-24 05:53:41Date Closed:2007-07-09 21:20:43
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Resources/res_jabber
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) res_jabber.patch
Description:tested on miranda and native gtalk IM, but seems to be gtalk's server related.
user can't add my asterisk's contact to list, cause can't get 'subscribed' state.

a FULL 'from' must be specified in answer.

bellow see a log from non-working condition.
patch attached.

****** ADDITIONAL INFORMATION ******

JABBER: asterisk INCOMING: <presence type="subscribe" to="private1@gmail.com" from="private2@gmail.com"/>

JABBER: asterisk OUTGOING: <presence type='subscribed' to='private2@gmail.com' from='private1@gmail.com'><status>Asterisk has approved subscription</status></presence>

JABBER: asterisk INCOMING: <presence type="error" to="private1@gmail.com" from="private2@gmail.com"><status>Asterisk has approved subscription</status><error code="400" type="modify"><bad-request xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/><text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">If set, the 'from' attribute must be set to the user's full JID.</text></error></presence>
Comments:By: Joshua C. Colp (jcolp) 2006-11-16 17:49:22.000-0600

Is this patch applicable mog? Need your confirmation before putting it in.
By: caspy (caspy) 2006-11-17 03:30:45.000-0600

'mog'?
By: Serge Vecher (serge-v) 2006-11-20 14:28:45.000-0600

caspy: mog is the nickname of developer (mogorman) this bug is assigned to ...
By: Jason Parker (jparker) 2007-02-21 15:11:58.000-0600

This hasn't been committed, but I'm not seeing this error.  Can you verify that you still see this error from the google servers?  They may have "fixed" something on their end, to allow a "normal" from.
By: Brad Templeton (bradtem) 2007-03-12 20:54:21

I can confirm I see the error (with 1.4.1).  Note that my username in jabber.conf does have username=account.asterisk@gmail.com/Talk with a resource.

JABBER: gtalk_account INCOMING: <presence type="subscribe" to="account.asterisk@gmail.com" from="private@gmail.com"/>

JABBER: gtalk_account OUTGOING: <presence type='subscribed' to='private@gmail.com' from='account.asterisk@gmail.com'><status>Asterisk has approved subscription</status></presence>
main*CLI>
JABBER: gtalk_account INCOMING: <presence type="error" to="account.asterisk@gmail.com" from="private@gmail.com"><status>Asterisk has approved subscription</status><error code="400" type="modify"><bad-request xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/><text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">If set, the 'from' attribute must be set to the user's full JID.</text></error></presence>


By: Russell Bryant (russell) 2007-03-28 13:21:46

caspy, Do you have a disclaimer on file?
By: Russell Bryant (russell) 2007-03-28 13:22:35

Ah, I see that this is just a one line patch.  The disclaimer is probably not necessary ...
By: Russell Bryant (russell) 2007-03-29 12:45:01

This patch has been applied to 1.4 and trunk in revisions 59363 and 59364, thanks!