[Home]

Summary:ASTERISK-07917: [patch] app_chanspy volume adjust broken for certain channel types
Reporter:Matthew Nicholson (mnicholson)Labels:
Date Opened:2006-10-11 20:21:16Date Closed:2006-10-13 12:07:08
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_chanspy
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_chanspy-voladjust-fix.diff
Description:app_chanspy does not set the CHANSPY_WRITE_VOLADJUST and CHANSPY_READ_VOLADJUST flags so volume adjustment does not work right for certain channel types.  The attached patch sets those flags.
Comments:By: Anthony LaMantia (alamantia) 2006-10-12 11:18:37

Looks Good, have you or anyone else testing the functionality of this patch on a production system yet?



By: Matthew Nicholson (mnicholson) 2006-10-12 11:52:46

No, I have not tested this in production, but I have tested it.  I am suprised no one else has noticed this issue.

By: Anthony LaMantia (alamantia) 2006-10-12 11:56:31

it looks good, i am going to need to review it, and ensure that no changes need to be made(which i don't think there will need to be) before it's commited.

By: Joshua C. Colp (jcolp) 2006-10-13 12:07:07

Fixed in 1.2 as of revision 45060, 1.4 as of revision 45066 and trunk as of revision 45067. Thanks Matt!