|Summary:||ASTERISK-07860: [patch] hardwired dchan channel number|
|Reporter:||Tzafrir Cohen (tzafrir)||Labels:|
|Date Opened:||2006-10-03 03:18:36||Date Closed:||2006-11-16 19:06:11.000-0600|
|Environment:||Attachments:||( 0) chanzap_dchannum.diff|
|Description:||chan_zap hardwires the number of the D channel: channnel no. 16 (in the span) for E1 and channel no. 24 for T1. It identifies E1 and T1 by the number of channels.|
The patch changes this slightly: If there are 31 channels, this is a E1, and the D chan will still be channel 16. Else just make the D chan the last channel.
As you can see, this does not change the case of E1 and T1. This does, however, enable Asterisk to work with spans that have the dchan as channel no. 3. (BRI)
****** ADDITIONAL INFORMATION ******
Note: if the patch is not accepted: what should be done if totalchannels is not 31 or 24?
|Comments:||By: Tzafrir Cohen (tzafrir) 2006-10-05 14:39:15|
Some inputs I got so far:
Aparantly it does work for several people. I got no negative feedback so far. Still very few cases.
What happens in the case of a line with non-standard D channel location? Case in question: a partial PRI line with 15 channels where the D channel is the first one.
I gather that both hte current code and my patch would handle it incorrectly. I'm not sure which of them is worse.
By: Michiel van Baak (mvanbaak) 2006-10-21 17:39:42
This one works for me in several setups:
inbound callcenter with 1 ISDN20 (ISDN30 with 10 channels disabled by telco)
normal PABX with 1 BRI (ISDN2 on normal ISDN line here in .nl)
NO bri/pri at all (IAX/SIP only setup)
By: Matthew Fredrickson (mattf) 2006-11-16 18:54:40.000-0600
Good idea! I like it.
By: Matthew Fredrickson (mattf) 2006-11-16 19:05:59.000-0600
Applied to trunk