Summary:ASTERISK-07818: [patch] addition to support timeout and warning into MeetMe
Reporter:Belaid Arezqui (areski)Labels:
Date Opened:2006-09-25 18:04:51Date Closed:2007-11-06 16:13:39.000-0600
Versions:Frequency of
Environment:Attachments:( 0) meetme_timeout_timelimit_v2.patch
Description:Add to MeetMe 2 similar options as in app_dial :

'S(x)' -- Kick the user 'x' seconds *after* he entered into the conference.
'L(x[:y][:z])' - Limit the conference to 'x' ms. Play a warning when 'y' ms are
left. Repeat the warning every 'z' ms. The following special variables can be used with this option:
* CONF_LIMIT_TIMEOUT_FILE       File to play when time is up.
* CONF_LIMIT_WARNING_FILE       File to play as warning if 'y' is defined.
The default is to say the time remaining.
Comments:By: Serge Vecher (serge-v) 2006-09-26 08:33:40

Alright, you've got some formatting problems in the patch:
1) Need "spaces" in here and similar lines:
+long warning_freq=0;
+char *warning_sound=NULL;
+char *end_sound=NULL;
2) Use 'tabs' for indenation, not 'spaces'
3) Use c-style (*/ /*) comments, not c++ (//)
4) Single line if constucts do not need curly brackets.

All of the above is covered by the CODING GUIDELINES file ;)

By: Belaid Arezqui (areski) 2006-09-26 09:52:29

Thanks, I read back the guidelines and fixed the previous issues.
You will find now meetme_timeout_timelimit_v2.patch and lmk :D

By: jmls (jmls) 2006-11-01 06:50:44.000-0600

housekeeping: can a developer look at this ?

By: jmls (jmls) 2006-12-01 12:38:57.000-0600

housekeeping: another month has passed ...

By: Belaid Arezqui (areski) 2006-12-01 12:54:08.000-0600

Is there anything I can do to make stuff easier for you guys !?

By: Serge Vecher (serge-v) 2006-12-01 13:09:47.000-0600

areski: could you please get some testers for this patch to try it out and report on the results?

By: Belaid Arezqui (areski) 2006-12-01 13:32:05.000-0600

hmmm, I don't have enough geek friends :D
FYI I use this patch on a production box since 3 months and got about 100 calls per day on meetme using this particular patch.

By: Serge Vecher (serge-v) 2006-12-01 15:32:13.000-0600

alright, put it on client's boxes then. Also, you can make some "asterisk" friends on #asterisk irc channel.

By: Digium Subversion (svnbot) 2007-11-06 16:13:38.000-0600

Repository: asterisk
Revision: 89069

U   trunk/CHANGES
U   trunk/apps/app_meetme.c
U   trunk/doc/tex/channelvariables.tex

r89069 | russell | 2007-11-06 16:13:37 -0600 (Tue, 06 Nov 2007) | 10 lines

Added the S() and L() options to the MeetMe application.  These are pretty
much identical to the S() and L() options to Dial().  They let you set
timeouts for the conference, as well as have warning sounds played to
let the caller know how much time is left, and when it is running out.

(closes issue ASTERISK-7818)
Reported by: areski
     meetme_timeout_timelimit_v2.patch uploaded by areski (license 29)