| Summary: | ASTERISK-07780: [patch] fixed two OSP application bugs | ||
| Reporter: | Di-Shi Sun (homesick) | Labels: | |
| Date Opened: | 2006-09-20 14:05:16 | Date Closed: | 2006-11-15 19:44:24.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_osplookup |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) osp_43306_b.patch | |
| Description: | The patch fixed 2 OSP application bugs. 1. If the OSP AuthRsp messages without destination protocol infomation, Asterisk hangs up the calls. 2. Generating wrong dial string (no in IAX2/[username[:password]@]peer[:port][/exten[@context]][/options] format) for IAX. The source code is re-formated. All tab are replaced by space. This patch is fully tested. ****** ADDITIONAL INFORMATION ****** Disclaimer signed by TransNexus, Inc. 1/27/05 | ||
| Comments: | By: Serge Vecher (serge-v) 2006-09-20 14:23:32 di-shi: it is best that you attach a patch here, that only addresses the bug fix and open another report for the whitespace fix -- thanks! By: Di-Shi Sun (homesick) 2006-09-21 15:27:58 Hi Serge, Thank you for your suggestion. I have tried to separate this patch. After hours trying, I have to give up. It is too difficult since we did the whitespace modification first, then fixed the bugs on the modifed files. I am very sorry for the inconvenience. We believe this patch is correct. We had full tested it. I will post different patches separately next time. Thanks again. Di-Shi Sun. By: Russell Bryant (russell) 2006-09-23 22:58:01 Why would you convert all tabs to spaces? That is contrary to the Asterisk coding guidelines. The file needs to stay indented with tabs and *not* spaces. Please post a patch that only contains the bug fixes. By: Di-Shi Sun (homesick) 2006-09-25 07:50:46 We changed tab to space because we met some problems for long functions and comments. It is difficult to read the code. Anyway, we will change it back and post it again. By: Di-Shi Sun (homesick) 2006-09-25 13:21:07 A updated patch (osp_43306_a.patch) is posted. The tab to space changes are removed. Please erase the old patch (osp_43306.patch). Thanks. By: Serge Vecher (serge-v) 2006-09-25 13:44:01 di-shi: thanks; but there still are whitespace changes in this patch that belong in another patch/bug report. For example, 1) - * + * 2) -#define OSP_TOKSTR_SIZE ((unsigned int)4096) /* OSP token string buffer size */ +#define OSP_TOKSTR_SIZE ((unsigned int)4096) /* OSP token string buffer size */ And others that are too numerous to list... Please remove any white-space changes from this patch. Thanks for following through ... By: Di-Shi Sun (homesick) 2006-09-25 15:22:57 It is my fault. Update again. Please remove osp_43306_a.patch. Thanks. By: jmls (jmls) 2006-11-01 06:19:14.000-0600 can we move this forward ? By: Di-Shi Sun (homesick) 2006-11-15 15:00:34.000-0600 The patch has been committed. Please close this ticket. Thanks. [scroll-keeper adds] trunk r. 47704 | ||