[Home]

Summary:ASTERISK-07779: [patch] missing locking in zt_unregister
Reporter:Tzafrir Cohen (tzafrir)Labels:
Date Opened:2006-09-20 04:17:52Date Closed:2008-06-07 12:06:49
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) zt_unregister-lock.diff
Description:The following snippet is from the end of zt_unregister:

       if (master == span)
               master = NULL;
       for (x=1;x<ZT_MAX_SPANS;x++) {
               if (spans[x]) {
                       maxspans = x+1;
                       if (!master)
                               master = spans[x];
               }
       }


It gives temporary values tha are invalid to both master and maxspans .
The values of those variables is used iv various places elsewhere.
Comments:By: Tzafrir Cohen (tzafrir) 2006-09-20 08:00:53

This is what I had in mind. The patch is actually vs. 1.2.8, but the code there has not changed. I figure it will apply vs. trunk as well.

Disclaimed.
By: jmls (jmls) 2006-11-01 06:13:09.000-0600

can we apply this to trunk ?
By: Joshua C. Colp (jcolp) 2006-11-16 11:42:46.000-0600

Reassigned to mattf for looking at at some point in time.
By: Tzafrir Cohen (tzafrir) 2006-11-16 12:09:16.000-0600

Still applies to trunk. The same code is still present in trunk.
By: Matthew Fredrickson (mattf) 2006-11-16 18:52:35.000-0600

Fixed in 1.2, 1.4, and trunk
By: Digium Subversion (svnbot) 2008-06-07 12:06:49

Repository: dahdi
Revision: 1608

U   branches/1.2/zaptel.c

------------------------------------------------------------------------
r1608 | mattf | 2008-06-07 12:06:49 -0500 (Sat, 07 Jun 2008) | 2 lines

Fix for ASTERISK-7779.

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=1608