Summary: | ASTERISK-07757: Syntax for 'w' optional delay is not as described in meetme description | ||
Reporter: | Bob Atkins (bob) | Labels: | |
Date Opened: | 2006-09-17 18:58:02 | Date Closed: | 2011-06-07 14:08:12 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Applications/app_meetme |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) app_meetme-patch.txt | |
Description: | The instructions for the show application meetme for the 'w' option do not properly reflect the syntax that is actually being expected by the meetme application. The instructions specify: 'w[(<secs>)]' -- wait until the marked user enters the conference The above instruction seems to indicate that at a minimum the optional delay value should follow the 'w' option enclosed in parenthesis. Eg: w(5). This syntax does not agree with the way the option is being processed by the app_meetme code which performs the following: /* Possible timeout waiting for marked user */ if ((confflags & CONFFLAG_WAITMARKED) && !ast_strlen_zero(optargs[OPT_ARG_WAITMARKED]) && (sscanf(optargs[OPT_ARG_WAITMARKED], "%d", &opt_waitmarked_timeout) == 1) && (opt_waitmarked_timeout > 0)) { timeout = time(NULL) + opt_waitmarked_timeout; } Based on the above code the syntax is really: 'w[secs]' -- wait until the marked user enters the conference This confusing syntax seems to have propagated a bug (bug id ASTERISK-7756) in the app_page application which was attempting to set a 5 second delay by putting the value inside parenthesis which caused the paged phones to hangup after approximately 3 seconds effectively breaking the app_page function. I have attached a patch to correct the error in the description of the 'w' syntax for consideration. | ||
Comments: | By: Tilghman Lesher (tilghman) 2006-09-17 22:06:56 No, the syntax is that it is optional and MUST be enclosed in parentheses. |