Summary:	ASTERISK-07743: [patch] zonedata.c does not contain data for Russian Federation
Reporter:	Pavel (pashah)	Labels:
Date Opened:	2006-09-14 01:45:31	Date Closed:	2008-06-07 13:17:27
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) disclaimer.pdf ( 1) indications.conf.sample.2.diff ( 2) indications.conf.sample.3.diff ( 3) indications.conf.sample.diff ( 4) zonedata.c.2.diff ( 5) zonedata.c.diff ( 6) zonedata.diff
Description:	zonedata.c does not contain tones for Russian Federation this trivial addition in the diff.
Comments:	By: Tilghman Lesher (tilghman) 2006-09-14 14:50:05 We need a disclaimer on file from you, before we can take a look at your patch. By: Pavel (pashah) 2006-09-15 01:57:41 disclaimer faxed. By: Paul Cadach (pcadach) 2006-10-02 15:45:52 "no" country uses the same indications as Russia/Kazakhstan/etc (CIS, exUSSR). By: Serge Vecher (serge-v) 2006-10-02 15:47:28 For indication additions, both zonedata.c and indications.conf need to be modified. By: Dmitry Kazarov (hanabana) 2006-10-04 15:15:45 "no" country uses 425/500,0/500 busy tone. exUSSR PBXs do not clearly recognize this tone. http://www.itu.int/ITU-T/inr/forms/files/tones-0203.pdf (page 21) states that busy tone have to be 425/400,0/400. Also ITU specifies waittone different from both Pashah's patch and current zonedata.c. By: caspy (caspy) 2006-10-25 09:05:50 Hmm... just my 2 cents. After searching for authoritative information i found, that according to WD 45.223-2001 (copy can be found here: http://www.aboutphone.info/lib/gost/45-223-2001.html ), that was confirmed by the 'ministry for communications and informatization of the russian federation' (see http://www.minsvyaz.ru/site.shtml?id=1806 ), tones for Russia should be (in syntax of indications.conf): ringcadence = 1000,4000 dial = 425 busy = 425/350,0/350 ring = 425/1000,0/4000 congestion = 425/175,0/175 callwaiting = 425/200,0/5000 ; dialrecall -- not defined ; dialrecall = !425/400,!0/40,!425/400,!0/40,!425/400,!0/40,425 record = 1400/400,0/15000 info = 950/330,1400/330,1800/330,0/1000 ; stutter -- not defined ; stutter = 425/400,0/40 specialdial = 425/400,0/40 Note, that we have defined "special dial tone", which should be used in case of enabled divert, for example. And we have NOT officially defined 'dialrecall' and 'stutter'. But it _seems_ to me, that 'specialdial' can be used for constructing them. By: Serge Vecher (serge-v) 2006-10-26 09:51:33 muzhiki: somebody please make a new patch! By: Dmitry Kazarov (hanabana) 2006-10-31 03:11:19.000-0600 I've uploaded a patch for zonedata.c with changes proposed by caspy. By: Serge Vecher (serge-v) 2006-11-02 15:34:53.000-0600 hanabana: also, please include the changes to indications.conf. Thanks! By: Dmitry Kazarov (hanabana) 2006-11-03 03:12:41.000-0600 OK, done. By: Serge Vecher (serge-v) 2006-11-09 09:23:45.000-0600 hanabana: I see that you are fixing the rincadence for [bg] indications.conf.sample.diff but it's a bit off ... ringcad_a_nce. -ringdance = 1000,4000 +ringcadance = 1000,4000 By: Tzafrir Cohen (tzafrir) 2006-12-19 06:35:57.000-0600 Why is this still marked "feedback"? By: Serge Vecher (serge-v) 2006-12-19 11:33:48.000-0600 hmm, I guess I was waiting for hanabana to make a fix as per my comment in 0054184. Hanabana: can you please make the last fix in your patch and confirm your disclaimer status? Thanks! By: Dmitry Kazarov (hanabana) 2006-12-20 03:37:54.000-0600 Ok, done By: Dmitry Kazarov (hanabana) 2006-12-20 04:18:08.000-0600 About disclaimer: it's quite inconvenient for me to make international fax calls or go to post office (really, USSR was rock-solid when I made use of offline post services last time). So I've upploaded the signed disclamer right here (disclamer.pdf file). Tell me if it's not enough. By: Tzafrir Cohen (tzafrir) 2007-02-06 10:48:28.000-0600 Are the patches disclaimed? If so: any further problems with this? By: Jason Parker (jparker) 2007-06-26 13:11:27 In the very near future, we will be implementing a new license agreement system here on Mantis.  You will be able to "sign" the license agreement/disclaimer online, if you're still willing to do so.  After that, I will go ahead and review and probably commit these patches. Please comment on this issue once you've filled out a license agreement on the new system - it should be implemented in the next few days. By: Jason Parker (jparker) 2007-07-30 17:45:27 hanabana, the new licensing system is in place.  Please see my previous comment. By: Dmitry Kazarov (hanabana) 2007-07-31 04:40:27 Ok, signed. By: Jason Parker (jparker) 2007-08-21 12:20:38 Can you also re-upload the patches?  The license agreement only applies to patches uploaded after it is filled out. By: Dmitry Kazarov (hanabana) 2007-08-27 05:03:50 Ok, done. By: Digium Subversion (svnbot) 2007-08-28 10:19:53 Repository: zaptel Revision: 2967 ------------------------------------------------------------------------ r2967 | russell | 2007-08-28 10:19:52 -0500 (Tue, 28 Aug 2007) | 2 lines Add Russian tones.  (issue ASTERISK-7743, hanabana) ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-08-28 10:20:35 Repository: zaptel Revision: 2968 ------------------------------------------------------------------------ r2968 | russell | 2007-08-28 10:20:34 -0500 (Tue, 28 Aug 2007) | 10 lines Merged revisions 2967 via svnmerge from https://origsvn.digium.com/svn/zaptel/branches/1.4 ........ r2967 | russell | 2007-08-28 10:38:03 -0500 (Tue, 28 Aug 2007) | 2 lines Add Russian tones.  (issue ASTERISK-7743, hanabana) ........ ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-08-28 10:23:05 Repository: asterisk Revision: 81226 ------------------------------------------------------------------------ r81226 | russell | 2007-08-28 10:23:04 -0500 (Tue, 28 Aug 2007) | 2 lines Add Russian tones.  (closes issue ASTERISK-7743, hanabana) ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-08-28 10:23:58 Repository: asterisk Revision: 81227 ------------------------------------------------------------------------ r81227 | russell | 2007-08-28 10:23:57 -0500 (Tue, 28 Aug 2007) | 10 lines Merged revisions 81226 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r81226 | russell | 2007-08-28 10:41:15 -0500 (Tue, 28 Aug 2007) | 2 lines Add Russian tones.  (closes issue ASTERISK-7743, hanabana) ........ ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2008-06-07 13:17:20 Repository: dahdi Revision: 2967 U   branches/1.4/zonedata.c ------------------------------------------------------------------------ r2967 | russell | 2008-06-07 13:17:19 -0500 (Sat, 07 Jun 2008) | 2 lines Add Russian tones.  (issue ASTERISK-7743, hanabana) ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=2967 By: Digium Subversion (svnbot) 2008-06-07 13:17:27 Repository: dahdi Revision: 2968 _U  trunk/ U   trunk/zonedata.c ------------------------------------------------------------------------ r2968 | russell | 2008-06-07 13:17:25 -0500 (Sat, 07 Jun 2008) | 10 lines Merged revisions 2967 via svnmerge from https://origsvn.digium.com/svn/zaptel/branches/1.4 ........ r2967 | russell | 2007-08-28 10:38:03 -0500 (Tue, 28 Aug 2007) | 2 lines Add Russian tones.  (issue ASTERISK-7743, hanabana) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=2968