Summary:ASTERISK-07731: [patch] ast_io_remove() does not properly decrement number of fds
Reporter:Earle Clubb (eclubb)Labels:
Date Opened:2006-09-12 12:09:19Date Closed:2006-10-02 12:28:11
Versions:Frequency of
Environment:Attachments:( 0) io_patch.txt
Description:In order for the number of fds to be decremented, ast_io_remove() first checks that the current context is not in use, then calls io_shrink() to remove the fd.  The check assumes that ioc->current_ioc is NULL if it's not in use.  This is an error because ioc->current_ioc is actually set to -1 when not in use.  The attached patch simply corrects the logic for the check.
Comments:By: Anthony LaMantia (alamantia) 2006-09-15 05:32:01

eclubb, thanks for the patch. If possible, please:

Get a disclaimer on file (see bottom of http://bugs.digium.com/main_page.php)[^] and confirm here with a note when you fax it in.

By: Earle Clubb (eclubb) 2006-09-19 13:27:47

Is it possible to disclaim specific changes? Both of the standard disclaimers seem to apply for all changes I'll ever commit. I'd rather do individual disclaimers than a global one. Is this possible?

By: Earle Clubb (eclubb) 2006-09-25 08:12:46

Disclaimer now on file.

By: Joshua C. Colp (jcolp) 2006-10-02 12:28:10

Fixed in 1.2 as of revision 44168, 1.4 as of revision 44169 and trunk as of revision 44171. Thanks!