Summary:ASTERISK-07726: [PATCH] ast_log() and ast_verbose() new-line mess
Reporter:Wojtek Kaniewski (wojtekka)Labels:
Date Opened:2006-09-12 07:06:03Date Closed:2006-09-28 13:10:20
Versions:Frequency of
Environment:Attachments:( 0) asterisk-1.2-newline.patch
( 1) asterisk-trunk-newline.patch
Description:1. Some ast_log() and ast_verbose() calls use formatting strings without the trailing '\n' and obviously it doesn't look nice in the console.

2. In some places ast_verbose() are called couple of times to display a single line of output. Depending on syslog daemon, this can look like this:

--- (0 headers 0 lines)
Nat keepalive

or like this:

--- (0 headers 0 lines)
--- (0 headers 0 lines) Nat keepalive
--- (0 headers 0 lines) Nat keepalive ---

The attached patch corrects all the calls without '\n' that I've found, except the ones that display error messages from external libraries (I'm unable to check these). Also I didn't touch mm_status() in app_voicemail.c, because the modification wouldn't be as trivial as the rest.


There's also a patch for 1.2 branch attached, because I didn't know if should open a separate bugreport or a single one will be fine.
Comments:By: Joshua C. Colp (jcolp) 2006-09-28 13:10:19

Fixed in 1.2 as of revision 43924, 1.4 as of revision 43933, and trunk as of revision 43934. Thanks!