Summary:	ASTERISK-07708: [patch][post 1.4] asterisk-sounds needs RPM spec file
Reporter:	Jonathan S. Shapiro (shap)	Labels:
Date Opened:	2006-09-09 16:16:31	Date Closed:	2011-06-07 14:03:08
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) sounds-spec.patch
Description:	Attached diff provides a RPM spec file for asterisk-sounds, following conventions previously used in core asterisk packages. As with core, it is now appropriate to run 'make spec' before building release tarball. Also, RPMVERSION variable is set in the Makefile rather than from the .version file, because no .version file exists. ****** ADDITIONAL INFORMATION ****** Since I don't have a disclaimer on file, I hereby place this file in the public domain.
Comments:	By: Tilghman Lesher (tilghman) 2006-09-09 16:20:40 You must have a disclaimer on file for us to take a look at this.  If you want to file the short form to place your contributions into the public domain, that's fine, but you still must have a disclaimer on file. By: Jonathan S. Shapiro (shap) 2006-09-09 16:48:27 It seems that I uploaded too soon. Some of the sounds in the asterisk-sounds package were apparently copied into core at some point, with the end result that a conflict results when the asterisk-sounds package is installed. Ultimately, the correct fix is to remove these sounds from the asterisk-sounds package and release asterisk-sounds-1.2.2. The list of conflicting files can be discovered by checking the 'rm' lines in the %install phase of this revised spec file. As an interim solution, I modified the spec file to hand-remove these files after the make install step and before packaging, which resolves the conflict. Since I'm not sure which asterisk release the files migrated in, I've set the "requires" tag to require asterisk >= 1.2.12, which is the one that I tested. By: Jonathan S. Shapiro (shap) 2006-09-09 16:55:34 Cordyon76: M original posting explicitly placed this contribution in the public domain, and that in the US this is a legally binding statement. However, I'll sign and fax in the non-exclusive assignment. By: Jonathan S. Shapiro (shap) 2006-09-09 17:02:12 Disclaimer has been faxed By: Serge Vecher (serge-v) 2006-09-13 08:44:20 ok, since this is a new feature, the patch needs to be redone against the latest trunk. Switching version/branch fields accordingly. By: jmls (jmls) 2006-11-01 05:50:58.000-0600 ok, since this is a new feature, the patch needs to be redone against the latest trunk. Thanks! By: jmls (jmls) 2007-01-01 12:50:43.000-0600 ping - can we have a patch for trunk, please ? Thanks. By: Jonathan S. Shapiro (shap) 2007-01-01 13:23:20.000-0600 I won't be doing that. I'm working on too many other things to have time to fiddle with trunk in the forseeable future. The existing SPEC is probably very close to right, but I don't have time to adjust it at this point. By: Jason Parker (jparker) 2007-01-02 12:37:12.000-0600 Since 1.4 and trunk use a different method of installing sounds now, I don't think we need this anymore.