| Summary: | ASTERISK-07705: two small tweaks for FreeBSD 6.1-STABLE | ||
| Reporter: | Ralf S. Engelschall (rse) | Labels: | |
| Date Opened: | 2006-09-09 12:56:07 | Date Closed: | 2006-09-14 17:12:06 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | In order to build Asterisk 1.2.12 under recent FreeBSD 6.1-STABLE and forthcoming versions I had to apply the following two patches: Index: channels/chan_skinny.c --- channels/chan_skinny.c.orig 2006-08-30 20:59:44 +0200 +++ channels/chan_skinny.c 2006-09-09 19:28:53 +0200 @@ -99,7 +99,7 @@ #define htolel(x) (x) #define htoles(x) (x) #else -#if defined(SOLARIS) || defined(__Darwin__) || defined(__NetBSD__) +#if defined(SOLARIS) || defined(__Darwin__) || defined(__NetBSD__) || defined(__FreeBSD__) #define __bswap_16(x) \ ((((x) & 0xff00) >> 8) | \ (((x) & 0x00ff) << 8)) Index: utils.c --- utils.c.orig 2006-07-12 15:54:10 +0200 +++ utils.c 2006-09-09 19:28:53 +0200 @@ -58,7 +58,10 @@ static char base64[64]; static char b2a[256]; -#if defined(__FreeBSD__) || defined(__OpenBSD__) || defined( __NetBSD__ ) || defined(__APPLE__) || defined(__CYGWIN__) +#if defined(__FreeBSD__) +#include <osreldate.h> +#endif +#if (defined(__FreeBSD__) && __FreeBSD_version < 601104) || defined(__OpenBSD__) || defined( __NetBSD__ ) || defined(__APPLE__) || defined(__CY /* duh? ERANGE value copied from web... */ #define ERANGE 34 | ||
| Comments: | By: Tilghman Lesher (tilghman) 2006-09-09 16:22:59 We need you to file a disclaimer before even looking at your prospective contributions. By: Ralf S. Engelschall (rse) 2006-09-10 01:56:50 I don't know how to "file a disclaimer" on your issue tracking system, but feel free to do whatever you want with my patches in all two filed issues (ASTERISK-7857915, ASTERISK-7857916). By: Tilghman Lesher (tilghman) 2006-09-10 07:49:20 Please read the information in the Main link at the top of each bugtracker screen and follow the instructions to file a disclaimer. By: Dinesh Nair (alphaque) 2006-09-14 05:52:32 What exact platform is this on ? I've been building the 1.2.x tarballs since 1.2.1 on freebsd 6.0, and now freebsd 6.1-stable without any build errors in chan_skinny.c and utils.c. a build of 1.2.12.1 today went just as well too. what were the build errors you were seeing ? By: Tilghman Lesher (tilghman) 2006-09-14 17:12:06 rse: please test your patches in the future before posting them on the bugtracker. | ||