[Home]

Summary:ASTERISK-07676: pciradio.c include moduleparam.h missing
Reporter:Marc Popp (iceberg13de)Labels:
Date Opened:2006-09-05 03:38:30Date Closed:2008-06-07 11:57:43
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:I could reproduce Issue ASTERISK-7207263.

 CC [M]  /root/install/zaptel-1.2.8/pciradio.o
/root/install/zaptel-1.2.8/pciradio.c:1811: error: parse error before "int"
/root/install/zaptel-1.2.8/pciradio.c:1811: warning: type defaults to `int' in declaration of `module_param'
/root/install/zaptel-1.2.8/pciradio.c:1811: warning: function declaration isn't a prototype
/root/install/zaptel-1.2.8/pciradio.c:1811: warning: data definition has no type or storage class

After adding this line (ASTERISK-45) to pciradio.c it was gone:
#include <linux/moduleparam.h>

****** ADDITIONAL INFORMATION ******

Testing system was:

SLES 9 SP3 - Kernel 2.6.5-7.276-default
Zaptel from ftp 1.2.8 (and 1.2.6 from bristuff)

This is my first issue. If any information is missing, please ask.
Comments:By: Joshua C. Colp (jcolp) 2006-09-07 22:22:41

Fixed in 1.2 as of revision 1431, and trunk as of revision 1432. Thanks!

By: Digium Subversion (svnbot) 2008-06-07 11:57:25

Repository: dahdi
Revision: 1431

U   branches/1.2/pciradio.c

------------------------------------------------------------------------
r1431 | file | 2008-06-07 11:57:13 -0500 (Sat, 07 Jun 2008) | 2 lines

Include moduleparam.h like every other module for certain 2.6 kernels (issue ASTERISK-7676 reported by iceberg13de)

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=1431

By: Digium Subversion (svnbot) 2008-06-07 11:57:43

Repository: dahdi
Revision: 1432

_U  trunk/
U   trunk/pciradio.c

------------------------------------------------------------------------
r1432 | file | 2008-06-07 11:57:42 -0500 (Sat, 07 Jun 2008) | 10 lines

Merged revisions 1431 via svnmerge from
https://origsvn.digium.com/svn/zaptel/branches/1.2

........
r1431 | file | 2006-09-07 23:17:16 -0400 (Thu, 07 Sep 2006) | 2 lines

Include moduleparam.h like every other module for certain 2.6 kernels (issue ASTERISK-7676 reported by iceberg13de)

........

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=1432