Summary:ASTERISK-07660: Keypad does not become DTMF
Reporter:dea (dea)Labels:
Date Opened:2006-09-01 17:33:19Date Closed:2006-09-01 20:40:28
Versions:Frequency of
Environment:Attachments:( 0) trunk-41765-eats-DTMF.diff
Description:Phones connected to chan_skinny cannot place calls.
I inserted a number of ast_log(WARNING.. statments and
followed key press through chan_skinny and into channel.c

Chan_skinny is setting the frametype to AST_FRAME_DTMF
before calling ast_queue_frame.  When the frame gets to
ast_waitfordigit_full the frametype is now set to AST_FRAME_NULL,
or more accurately, the first frame is set to AST_FRAME_DTMF_BEGIN
and each frame after is set to AST_FRAME_NULL.

So ast_waitfor_digit_full doesn't find the keypress/DTMF and calls
cannot be completed from SCCP phones.
Comments:By: dea (dea) 2006-09-01 18:28:20

This was not a bug in chan_skinny, but in channel.c.

A multi-line else clause was not wrapped in {} causing __ast_read() to
NULL out frames regardless of the test results.

By: Joshua C. Colp (jcolp) 2006-09-01 19:41:15

I'm currently talking to the maintainer of chan_skinny, needless to say your patch isn't exactly right.

By: Jason Parker (jparker) 2006-09-01 20:40:28

Fixed in trunk, r41788.  Different patch used.

edit: changed revision number