|Summary:||ASTERISK-07650: [patch] Chan_ooh323 needs to be taught about VLDTMF to compile against current trunk|
|Date Opened:||2006-08-31 20:18:55||Date Closed:||2006-09-14 05:19:45|
|Environment:||Attachments:||( 0) chan_ooh323-VLDTMF-v2.diff|
( 1) vldtmf_new.diff
|Description:||The VLDTMF changes that have been merged into trunk require that|
chan_ooh323 be updated.
I am a little concerned that I munged porting these changes, but
internal testing with the channel sending and receiving DTMF has
been positive. I should caveat that with a warning that I do not
have an H323 endpoint that uses RFC2833, but I modeled the changes
after chan_sip and the code compiles without error and completes
the none RFC2833 DTMF relay properly
|Comments:||By: Kaloyan Kovachev (knk) 2006-09-01 04:30:54|
ooh323_digit_end function is calling again ast_rtp_senddigit_begin instead of ast_rtp_senddigit_end
By: dea (dea) 2006-09-01 10:55:41
Good eyes. A simple cut-n-paste error, fixed in v2
By: Anthony LaMantia (alamantia) 2006-09-11 12:00:03
i have reviwed these changes and will commit them to the addons-trunk
thanks again for your contributions to asterisk
By: dea (dea) 2006-09-12 01:30:59
My apologies, but the last hunk in this patch is actually part of the
packetization patch, and should be removed.
Sorry for any trouble this caused.
By: Anthony LaMantia (alamantia) 2006-09-12 13:57:47
do you have a patch for the VLDMTF issue that we can still use?
By: dea (dea) 2006-09-12 14:01:17
I can upload another version, or just delete the last 10 lines of the v2 patch attached to this bug.
By: Anthony LaMantia (alamantia) 2006-09-13 12:43:24
is the new patch just posted ok with you?
By: dea (dea) 2006-09-13 15:42:23
It looks clean, as in no pollution from other projects. I am not sure it it the 'right' way, but it seems to work OK here.
By: Anthony LaMantia (alamantia) 2006-09-13 16:34:48
this has been done, is there anything else a-rye that you notice?
By: dea (dea) 2006-09-13 20:38:59
Looks good to me.