| Summary: | ASTERISK-07649: [patch] reload_config always returns 0 | ||
| Reporter: | dea (dea) | Labels: | |
| Date Opened: | 2006-08-31 19:11:39 | Date Closed: | 2006-09-01 20:41:50 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_skinny |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) skinny_reload-2.diff | |
| Description: | All return paths in reload_config() return 0, causing load_module() to skip registering cli commands. Possibly related is that even with a successful load of chan_skinny, the channeltype is not registered. | ||
| Comments: | By: Jason Parker (jparker) 2006-08-31 19:34:05 Try this patch, and let me know if that seems right. By: dea (dea) 2006-08-31 19:58:35 Yup. I had about the same changes in a local tree while working through this. A couple questions/points- The test (res == -1) can never be true with the current reload_config The test for (!res) around ast_channel_register can be changed to (res) By: Jason Parker (jparker) 2006-08-31 20:12:51 oops - an important part of the previous patch somehow disappeared. and the check for res around ast_channel_register was useless, in my opinion, so I removed it. By: dea (dea) 2006-08-31 21:05:11 That makes sense now, and I agree that the check around ast_channel_register is/was useless. By: Jason Parker (jparker) 2006-09-01 20:41:50 Fixed in svn trunk, r41789. | ||