Summary:ASTERISK-07625: [patch] fix crash when mixmonitor tries to stop monitors after channel.c does the same on hangup
Reporter:Tim Ringenbach at Asteria Solutions Group (tim_ringenbach)Labels:
Date Opened:2006-08-29 16:59:22Date Closed:2011-06-07 14:01:06
Versions:Frequency of
Environment:Attachments:( 0) mixmonitor.diff
( 1) mixmonitor-r41673.diff
Description:This fixes a crash that happens when app_mixmonitor decides to stop spying on a channel after channel.c's hangup also decides to make it stop spying on the channel. The patch is against and that's what it has been tested against.
Comments:By: Joshua C. Colp (jcolp) 2006-08-30 10:22:46

Can you please update your patch to the latest 1.2 and try it? Mixmonitor was dramatically changed after so much that your patch won't even compile.

By: Tim Ringenbach at Asteria Solutions Group (tim_ringenbach) 2006-09-01 10:44:59

Here's a new diff. Sorry, the only testing I've had time to do yet is that it compiles.

By: Joshua C. Colp (jcolp) 2006-09-01 11:15:53

You should also check to make sure that mixmonitor->spy.chan exists, as it may be NULL... and I would feel much more comfortable if you could test this out for a day for example, I'm afraid a weird combination of events might come up and it ends up causing more crashes.

By: Joshua C. Colp (jcolp) 2006-09-03 18:41:56

This has been deprecated by the simplification that occured previously, and now by another major change in trunk.