Summary:ASTERISK-07565: [patch] Channel flag ZT_FLAG_OPEN setting and clearing are not atomic
Reporter:matti (matti)Labels:
Date Opened:2006-08-20 03:29:01Date Closed:2006-11-16 17:14:14.000-0600
Versions:Frequency of
Environment:Attachments:( 0) patch3
Description:Channel flag ZT_FLAG_OPEN setting in function zt_specchan_open and clearing in function zt_specchan_release are not atomic. Some other function could change the flags of the channel at the same time incoherently. Those two functions should be added spin_lock_irqsave of the channel lock before changing the flag and spin_unlock_irqrestore thereafter.
Comments:By: matti (matti) 2006-09-01 00:15:32

I have disclaimer on file.

I no longer think this is trivial. In SMP computers this error could well happen, e.g. when someone runs ztcfg at the same time as asterisk starts or stops.

By: Serge Vecher (serge-v) 2006-09-01 08:54:48

Matti: can you please fix up the spacing in the patch to use tabs, not spaces please.

By: jmls (jmls) 2006-10-31 13:37:05.000-0600

Matti: any chance of getting that updated patch ? Thanks.

By: matti (matti) 2006-11-01 00:11:15.000-0600

I uploaded a new patch against a newer version of zaptel.c.

By: jmls (jmls) 2006-11-01 04:49:59.000-0600

what version of zaptel.c was this new patch against ?

By: matti (matti) 2006-11-02 00:54:39.000-0600

patch3 was against zaptel.c Revision 1469.

By: Matthew Fredrickson (mattf) 2006-11-16 17:13:33.000-0600

Fixed in 1.2, 1.4, and trunk