[Home]

Summary:ASTERISK-07558: [patch] Successful call park does not read back parking location
Reporter:robf (robf)Labels:
Date Opened:2006-08-19 12:26:35Date Closed:2006-08-19 23:26:48
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Resources/res_features
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) M7762.txt
Description:I don't know how long this has been going on, but I haven't been getting readbacks of the parking spot when I park a call.  I've finally tracked it down to a single line in res/res_features.c that was last changed by 'METERMAIDS' patchset, rev 36055 on trunk.  As of rev 40521 on trunk (today), it's line 425 in res/res_features.c.  If someone in the know would take a look at it, I'm sure it can be fixed quickly.  I suspect there's some boolean operator precedence problem, and that an additional set of parantheses, or other minor change, will solve the problem.

****** ADDITIONAL INFORMATION ******

Here's the line:

if (peer && !pu->parkingnum == -1) /* Only say number if it's a number */

Should it be?

if (peer && !(pu->parkingnum == -1)) /* Only say number if it's a number */

or:

if (peer && pu->parkingnum != -1) /* Only say number if it's a number */

???
Comments:By: Clod Patry (junky) 2006-08-19 21:10:26

good catch, your logic solves the issue.
Thanks.
By: Joshua C. Colp (jcolp) 2006-08-19 23:26:48

Fixed in trunk as of revision 40599. Thanks to both of you!