Summary:ASTERISK-07552: [patch] Suggested fix for formatting issue in make menuselect
Reporter:Kenneth Shumard (kshumard)Labels:
Date Opened:2006-08-18 20:02:13Date Closed:2011-06-07 14:07:49
Versions:Frequency of
Environment:Attachments:( 0) buildtools.patch
Description:app_voicemail defines *tdesc differently depending on build options. The menuselect appearance of app_voicemail in the Applications menu does not account for this, and displays all versions of *tdesc instead of a sane default:

                                 [*] 68. app_voicemail

                         Comedian Mail (Voicemail System) with ODBC Storage
Comedian Mail (Voicemail System) with IMAP Storage
Comedian Mail (Voicemail System)


This patch modifies build_tools/prep_moduledeps to add "m 1" to the grep in get_description, so that only the first instance of *tdesc is used. app_voicemail is also changed so that the default (non-ODBC, non-IMAP) is defined first. It's quite likely my use of #ifndefs is not optimal, but this does still let voicemail compile and displays app_voicemail's <displayname> properly in menuselect. I'm curious to know what the "proper" way of doing this would be, or even if I'm on the right track.

Also included are fixes to the spelling of "delimited" in one app and in the menuselect README.
Comments:By: Jason Parker (jparker) 2006-08-19 00:48:13

-m is not a valid option to Solaris grep.  Can we change this to use something like the following instead?

TDESC=`cat $x | grep -e *tdesc | head -n1 | cut -f 2 -d '"'`

By: Serge Vecher (serge-v) 2006-09-06 12:15:47

kshumard: need new patch here ;)

By: Kenneth Shumard (kshumard) 2006-09-16 13:58:38

We can probably just close this issue. The build_tools/prep_moduledeps get_description() function has been rewritten since I posted the first attempt. There are still some issues the way it uses AST_MODULE_INFO (app_voicemail and chan_zap don't report properly), but I won't suggest a patch at this time. I'm not involved enough with the menuselect effort to know the best way to resolve this.

By: Jason Parker (jparker) 2006-09-18 14:06:40

already changed when the new module loader went in