|Summary:||ASTERISK-07464: [patch][post 1.4] Language support for Brazilian Portuguese|
|Reporter:||Celso Porto Fassoni (cfassoni)||Labels:|
|Date Opened:||2006-08-04 12:22:23||Date Closed:||2006-11-01 12:24:44.000-0600|
|Environment:||Attachments:||( 0) lang_ptbr_svn_38852_v2.patch|
( 1) lang_ptbr_svn_38852.patch
|Description:||The Portuguese Language spoken in some countries like Portugal and Brazil needs|
some adaptations in the code in order to make the pronunciation be grammatically correct.
The Asterisk code already support Portuguese language but as spoken in Portugal and thus need some adaptations for Brazilian speekers.
These patch has been tested for some months and it has been accepted by a lot of Asterisk users in Brazilian community.
Hope to have this feature integrated in Asterisk 1.2.x and future versions.
****** ADDITIONAL INFORMATION ******
New language code is pt_BR.
Additional information could be found in (Portuguese only):
|Comments:||By: Russell Bryant (russell) 2006-08-04 13:50:19|
A couple of initial comments ...
1) There are a lot of places in the patch where you have used spaces instead of tabs for indentation. Please convert the code to only use tabs to be consistent with the rest.
2) I would also encourage you to take a look at configs/say.conf.sample in the trunk. Instead of writing code for every language to specify how to say numbers and dates, a new configurable interface has been created. However, not very many languages have been converted over. A contribution of this language in that syntax would also be very useful.
By: Celso Porto Fassoni (cfassoni) 2006-08-04 20:17:39
1) Indentation fixed, new file uploaded (v2).
2) I agree and I'm already working on that. But I think most of users won't update their systems very quickly when new version be ready and thus it would be great if the patch could be incorporated in version 1.2.x tree. It will also be very easy to users who install their system using packages like deb or rpm.
By: Caio Begotti (caio1982) 2006-08-29 15:57:54
Hi, I've adapted cfassoni's patch and it's now default in the official Debian packages. Also, I have it applied and working fine in at least 10 machines with lots of others in queue for new installations since weeks so it'd really be great to get into Asterisk, so we won't have to mantain these kind of things separated.
Russel, it's not only a matter of modifying the Say() application. We tried some workarounds adjusting the voicemail messages and say commands but it didn't worth the job (poor quality solution and not a real and correct brazilian portuguese).
By: Caio Begotti (caio1982) 2006-09-11 08:39:43
Hello, any new comments about how and when to merge this patch into 1.4 guys?
By: Steve Murphy (murf) 2006-11-01 12:17:37.000-0600
Added this to the trunk version; see v 46773 and 46774.
By: Steve Murphy (murf) 2006-11-01 12:24:43.000-0600
merged, karmalized, and now... closed!