Summary:ASTERISK-07444: app_directory does not work with odbcstorage
Reporter:Matthew Nicholson (mnicholson)Labels:
Date Opened:2006-08-02 11:00:07Date Closed:2006-08-02 14:02:39
Versions:Frequency of
Description:Currently app_directory does not work with odbcstorage.  This is because app_directory.c looks for the voicemail greeting files on the file system.  If app_directory (and app_voicemail) were modified to use the same functions to store and retrieve greeting files, the problem would be solved.


I wrote code for asterisk 1.2 to fix this issue.  This involved moving the message storage parts of app_voicemail.c into res_vmstorage.c and then making app_directory use the RETRIEVE and DELETE macros from app_voicemail.c now located in res_vmstorage.

I can update the patches I created to apply to the latest 1.2 or even trunk, the problem is, some of the functions I moved to res_vmstorage.c have changed since I moved them and figuring out exactly what changed is complicated without just copying the functions over again.  If the code was written and commited to trunk then future changes would be made in res_vmstorage and would not suffer from this synchronization issue.
Comments:By: Serge Vecher (serge-v) 2006-08-02 11:45:41

are you sure you've checked 1.2.10? The patch in 7349 did exactly that AFAIK.

By: Matthew Nicholson (mnicholson) 2006-08-02 12:59:25

Ok, it looks like that has been fixed since I last checked.  I still like my fix (less duplication between app_directory and app_voicemail, but it is working).

By: Serge Vecher (serge-v) 2006-08-02 13:39:43

an effort to reduce code duplication has merit. If you want to post your patch, perhaps this can be looked at after 1.4 split.

By: Matthew Nicholson (mnicholson) 2006-08-02 13:58:16

I may take a stab at a new patch.

By: Serge Vecher (serge-v) 2006-08-02 14:02:39

Alright, I will suspend this issue for now. When you have a new patch available after 1.4 is forked, please feel free to reopen the bug with that patch attached. Thanks.