[Home]

Summary:ASTERISK-07421: Call failures with branch 1.2 r38420 chan_sip.c
Reporter:Andrew Lindh (andrew)Labels:
Date Opened:2006-07-29 17:35:43Date Closed:2006-07-31 09:22:15
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/Interoperability
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) sip_debug.txt
Description:Update to 1.2 r38420 chan_sip.c causes call failures now (for me anyway). SIP calls from phones (polycom SIP 1.6.7) always fails to know what I'm calling and
drops to invalid.

It's in this section of chan_sip.c

>          /* Skip any options */
>          if ((a = strchr(uri, ';'))) {
> +                *a++ = '\0';
> +                b = a;
> +        } else {
> +                b = uri;
> +        }
> +
>          /* Get the target domain */
> +        if ((a = strchr(b, '@'))) {
> +                *a++ = '\0';
>          } else {        /* No username part */
> +                a = b;
>                  uri = "s";        /* Set extension to "s" */
>          }

The issue is in the To:
 To: <sip:310@asterisk;user=phone>;tag=xxxxx
I think it starts looking for the @ in the "user=phone" part.....

Or whatever....it still fails now. Always setting "b=uri" makes it work again.
Comments:By: Andrew Lindh (andrew) 2006-07-29 17:37:50

This was the "fix" related to bug 7535 and 7552

But since this "fix" is commited it's kind of a new bug now...

SIP debug uploaded for "301" calling "391" (and failing)


By: Joshua C. Colp (jcolp) 2006-07-29 18:01:00

Can you put up a sip debug of the dialog? Thanks.
By: Joshua C. Colp (jcolp) 2006-07-29 18:01:37

Eep - thanks.
By: Joshua C. Colp (jcolp) 2006-07-29 18:04:18

I know why now... give me a wee bit to fix this up
By: Joshua C. Colp (jcolp) 2006-07-29 18:20:10

I *think* I'm done... wait around 15 minutes for this latest commit to get to the mirrors, test, and if it still fails I'll try again... SIP URI parsing is fun.
By: Andrew Lindh (andrew) 2006-07-29 18:25:52

It works again, thanks!
By: Joshua C. Colp (jcolp) 2006-07-29 18:27:57

Be gone! Fixed in latest 1.2
By: Serge Vecher (serge-v) 2006-07-31 09:22:15

for the archives, committed to 1.2 branch in r38501.