Summary: | ASTERISK-07408: [patch] Fastart unexpectedly disabled : flag mask overlapping | ||
Reporter: | phsultan (phsultan) | Labels: | |
Date Opened: | 2006-07-28 04:22:44 | Date Closed: | 2006-08-04 15:27:28 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Channels/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) ooh323c-trunk-faststart.1.patch ( 1) ooh323c-trunk-faststart.2.patch | |
Description: | The value of the 'mediawaitforconnect' configurable parameter alters 'faststart'. Thus, disabling 'mediawaitforconnect' (this one is set to FALSE by default) will also disable 'faststart'. It looks like OO_M_MEDIAWAITFORCONN flag value overlaps with OO_M_FASTSTART in ooh323c/src/ooCalls.h. The attached patch solves this issue. Disclaimer has been sent. ****** ADDITIONAL INFORMATION ****** Asterisk revision : 38348 ooh323c revision : 265 Setup : call from a Cisco 7960 SIP phone to H323 SJphone. Note : a call from SJPhone to Cisco works as expected. | ||
Comments: | By: Objective Systems (objsys) 2006-08-01 13:18:55 Hi Phsultan, I guess your last fix, will have solved this problem. I don't think changing value of this parameter is necessary. Let us know keeping this value, still creates a problem for you. Regards, Avin Patel Objective Systems Inc By: phsultan (phsultan) 2006-08-02 04:00:23 Hi Avin, actually it only apparently solves the problem : the 'ooh323 show config' CLI command shows the expected values, *but* the FastStart procedure is still not triggered when you keep the default config file. This new patch solves the issue without changing the value of OO_M_MEDIAWAITFORCONN, which I understand you want to keep close to OO_M_FASTSTART because of the dependency between these parameters. By: Objective Systems (objsys) 2006-08-02 07:35:44 I will incorporate it, As it solves this problem. Thanks, Avin Patel Objective Systems Inc By: Serge Vecher (serge-v) 2006-08-02 08:43:12 committed to asterisk-addons r267 by objsys By: phsultan (phsultan) 2006-08-04 11:18:59 Avin, I reopen this one because the OO_TESTFLAG macro now returns true for OO_M_MEDIAWAITFORCONN even with the default values (faststart=yes, mediawaitforconnect=no). This is normal, because OO_M_MEDIAWAITFORCONN is two bits long : #define OO_TESTFLAG(flags,mask) ((flags & mask) != 0) By: Objective Systems (objsys) 2006-08-04 13:17:21 Hi phsultan, I have added fix in svn addons-1.2 branch. You can be able to download fix from this branch. Thanks for pointing out this problem/bug. Regards, Avin Patel By: phsultan (phsultan) 2006-08-04 14:24:11 Avin, thanks for the fast replies, and sorry to insist on this ;) the latter problem remains, eg 'mediawaitforconnect' is set even when keeping the default values (tested in asterisk-addons-1.2, shown with an ethereal capture). You can issue the following commands that put in evidence the configuration problem, after a fresh Asterisk restart : --------------- CLI config looks OK : *CLI> ooh323 show config Objective Open H.323 Channel Driver's Config: IP:Port: 10.0.0.1:1720 FastStart yes Tunneling yes CallerId asterisk MediaWaitForConnect no Gatekeeper: No Gatekeeper H.323 LogFile: /var/log/asterisk/h323_log Context: default Capability: 0x6 (gsm|ulaw) DTMF Mode: rfc2833 AccountCode: ast_h323 AMA flags: Unknown Aliases: 100 ObjSysAsterisk *CLI> --------------- log file does not look OK : [758](root@freepbx)# cat /var/log/asterisk/h323_log | grep MediaWaitForConnect 21:05:05:075 MediaWaitForConnect - enabled [759](root@freepbx)# Avin, do you plan to include your changes in asterisk-addons trunk? Philippe By: Objective Systems (objsys) 2006-08-04 15:27:28 Hi Phsultan, I don't see disabling mediawaitforconnect disables faststart. If you think it is happening different. Than open new bug. Put all the steps(commands run & changes made) you do create the problem you face. This bug is done. Regards, Avin Patel |