Summary:ASTERISK-07395: When dialing from console, Asterisk doesn't put the contact as it has to
Reporter:Amin (key2)Labels:
Date Opened:2006-07-25 09:47:47Date Closed:2006-07-26 10:28:29
Versions:Frequency of
Description:exten => 1234,1,Dial(foo@bar.com)
CLI> dial 1234@default

From: "something" <sip:@192.168.x.x>;tag=xxxx
Contact: <sip:@192.168.x.x>


static void initreqprep(struct sip_request *req, struct sip_pvt *p, int sipmethod)
if (!l)
   l = default_callerid;

Has to be replaced by:
if (ast_strlen_zero(l))
l = default_callerid;
Comments:By: Serge Vecher (serge-v) 2006-07-25 10:13:22

while dialing from console is important, it definately does not qualify this bug as 'major'.

As per bug guidelines, please do a sip debug without and with the patch as follows:
As per bug guidelines, you need to attach a SIP debug trace illustrating the problem. Please do the following:
1) Prepare test environment (reduce the ammount of unrelated traffic on the server);
2) Make sure your logger.conf has the following line:
  console => notice,warning,error,debug
3) restart Asterik.
4) Enable SIP transaction logging with the following CLI commands:
set debug 4
set verbose 4
sip debug
5) Save complete console log to file and _attach_ said file to the bug.

Also, if you plan on contributing more patches to the Project (as I think you do), can you please:
a) get a disclaimer on file and report here when done? See bottom of http://bugs.digium.com/main_page.php
b) familiarize yourself with patch-making process and make a patchfile with your change? http://www.asterisk.org/developers/Patch_Howto


By: Brian West (bkw918) 2006-07-25 10:25:57

Its one line... it doesn't need a disclaimer.


By: Serge Vecher (serge-v) 2006-07-25 10:33:46

bkw918: please read a sentence above item a)

By: Joshua C. Colp (jcolp) 2006-07-26 10:28:28

Fixed in 1.2 and trunk, thanks.