Summary:ASTERISK-07350: Sound files minutes.gsm and seconds.gsm do not get installed
Reporter:gkloepfer (gkloepfer)Labels:
Date Opened:2006-07-17 16:08:24Date Closed:2006-09-26 16:38:43
Versions:Frequency of
Description:The sound files minutes.gsm and seconds.gsm included in core Asterisk sounds subdirectory do not get installed by the Makefile.  This is because they are not included in insanely long the 'for x in sounds...' statement in the Makefile.  The file hours.gsm also does not get installed as well, but it is duplicated under the asterisk-sounds tree.


I am not providing a patch for this because it can be solved in one of two ways:  Either put minutes/seconds.gsm into asterisk-sounds, or correct the Makefile for the core Asterisk installation.  If the Makefile is patched, it should include seconds* minutes* hours* in the statement beginning 'for x in sounds/demo-*'.
Comments:By: Jason Parker (jparker) 2006-07-17 16:29:31

I think sounds/*.gsm might be a little better than listing every single file...  If you look just a few lines below that, you'll see it doing images/*.jpg

By: gkloepfer (gkloepfer) 2006-07-18 08:46:49

That sounds like a good idea - personally I feel that the way the install works for the sound files is rather problematic at best and could probably be redone to be more scalable.  However, I'm not sure I'm the one to try to do that.

By: Serge Vecher (serge-v) 2006-07-18 09:03:23

is this an issue in trunk? 1.2 will be obsolete very soon ...

By: gkloepfer (gkloepfer) 2006-07-19 00:51:21

I'm not running trunk...unfortunately.  Since trunk seems to handle the sound installation entirely different from 1.2, I would imagine that it is fixed, but I can't tell for sure.  Actually, I can't even figure out where the sound files are located in trunk (but am happy to see that the cumbersome sound file install process has been replaced :-).

By: Steve Murphy (murf) 2006-09-06 15:06:08

Oh, I'm just seeking old bugs that are easy to fix. I added these to the makefile in 1.2 and ran an install. looks good. I'll commit the changes and close this bug. Hope I'm not committing some attrocious offense hereby!

By: Steve Murphy (murf) 2006-09-06 15:19:24

OK, I added the 3 files to the Makefile via revision 42150. It aint the best solution, but it hopefully will work, and we've done it right in trunk. I guess the old saying "Anything worth doing, is worth over-doing" applies here.

By: Jason Parker (jparker) 2006-09-26 16:38:43

This was already fixed by murf in revision 42150.