[Home]

Summary:ASTERISK-07328: [patch] whitespace fixing
Reporter:Tristan Mahe (tristan_mahe)Labels:
Date Opened:2006-07-12 10:55:50Date Closed:2006-07-14 08:39:13
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Applications/app_queue
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) svn-diff-resultv2.diff
Description:as title, this patch fixes whitespace in app_queue.c according to CODING-GUIDELINES
Comments:By: Tilghman Lesher (tilghman) 2006-07-12 11:26:28

Please upload your patch to issue 7476, not create a new issue.

By: Serge Vecher (serge-v) 2006-07-12 11:55:56

ok, hopefully this will clarify the confusion. I have asked you to open a new bug for a whitespace only patch from 7476 without completely checking the patch first. On second reading, I see that the patch contains code changes in addition to whitespace fixes. Sorry about that.

Please upload a new patch here that only does whitespace fixing in app_queue.c. Thanks!

By: Tristan Mahe (tristan_mahe) 2006-07-13 03:44:00

If you feel it is usefull the patch is uploaded without my changes in it...

By: Serge Vecher (serge-v) 2006-07-13 10:19:46

hmm, patch failed to apply to current trunk. Can you please make changes on a clean trunk check out and try again? Thanks!

By: Tilghman Lesher (tilghman) 2006-07-14 00:15:15

I honestly cannot see any difference between any two lines diff'ed in your patch.  The patch must either be corrupt or there's something else weird on your system.

By: Tilghman Lesher (tilghman) 2006-07-14 08:39:13

I went ahead and found some whitespace violations in app_queue.c, but without using your patch.  If you find some that I've missed (and you can fix your patch output), please reopen this bug and post that patch.