Summary:ASTERISK-07278: [patch] Play announcement to caller just before bridging
Reporter:Tristan Mahe (tristan_mahe)Labels:
Date Opened:2006-07-04 09:10:06Date Closed:2007-07-05 17:07:10
Versions:Frequency of
Environment:Attachments:( 0) diff.trunk
( 1) patch-1.2v2.diff
( 2) patch-trunkv3.diff
Description:This patch add annoucements to the caller to signal bridging is about to be done just before the effective bridge...

- Adds a config entry for the file to play ( queue-callerannounce )

It's quite usefull when music on hold is conversations !

This patch is tested on my production system right now and working without troubles...

Please provide reports about this patch and the way it was coded because it's my first * patch, I need to improve !
Comments:By: Jason Parker (jparker) 2006-07-04 19:52:32

Please read the CODING-GUIDELINES file.  There are certain formatting issues that need to be resolved in this patch.

By: Serge Vecher (serge-v) 2006-07-05 11:20:17

Also, since this is a new feature, the patch needs to be against trunk, not 1.2

By: Tristan Mahe (tristan_mahe) 2006-07-07 04:02:15

I'm working on porting it to trunk but I use it on 1.2 on my production server, that's why it is against 1.2 :)

I must be dumb because I'm unable to find CODING-GUIDELINES :/

By: Serge Vecher (serge-v) 2006-07-07 08:54:13

./asterisk/doc/CODING-GUIDELINES ;)

By: Tristan Mahe (tristan_mahe) 2006-07-12 10:01:20

Hi, added a patch that applies against trunk 37433
and branch 1.2 same rev...

Added also the result of a svn diff app_queue.c ;)

I read CODING-GUIDELINES and tried to improve my coding.

I'm waiting for your comments to improve better !!!

It is now in production for 5 days 24/24 without failure...

By: Serge Vecher (serge-v) 2006-07-12 10:25:37

1. Can you please get a disclaimer on file and confirm when done? See bottom of this page http://bugs.digium.com/main_page.php
2. You are still using spaces intstead of tabs for tabulation in patch-trunk.diff. 3. Also, no need for adding two blank lines, one will suffice.
4. Since svn-diff-result.diff is a white-space fix for app_queue, please open a new bug report and attach that patch there.


By: Tristan Mahe (tristan_mahe) 2006-07-12 11:00:14

Disclaimer faxed a few minutes ago

Also attached a fixed patch with the tabs and blank lines removed ...

By: Serge Vecher (serge-v) 2006-07-12 11:04:06

sorry to be nitpicky, but please add a tab between code and comment here:
+ char sound_callerannounce[80];/*!< Sound file: Custom announce for caller, no default */

also, the closing brace in the last block of the patch is not aligned with the if.

By: Jason Parker (jparker) 2006-07-12 11:12:08

Actually, it is recommended to use spaces in that instance.  If one person uses 4 spaces per tab, and another uses 8, it will be misaligned.

By: Tristan Mahe (tristan_mahe) 2006-07-12 11:36:54

Well, I don't know anymore what to do lol,

I opened a new bug report for svn-diff-result.diff and it was told to me that I need to upload it to this bug report...

And what about the formatting ?

Attached patch with the correct formating ;)

By: Tristan Mahe (tristan_mahe) 2006-07-13 03:47:43

attached branch 1.2 with correct formating for those who wants to use it in production like I do ;)

Waiting now for comments...

By: Tristan Mahe (tristan_mahe) 2006-07-17 04:18:52

Just a quick note to tell that svn-diff-result should be deleted as it is only reformatting to the way I code internally... ( bug 7523 should also be closed )

This patch is now working in production for 1week+ without troubles and I'm adding
a callerannounce override with the a() option ( Like A() is for members ) ...

By: jmls (jmls) 2006-11-01 05:11:12.000-0600

would you be able to upload a patch that applies against trunk ? Thanks

By: Tristan Mahe (tristan_mahe) 2006-11-03 10:53:11.000-0600

patch against new /trunk on its way... expected arrival on monday ;)

By: Serge Vecher (serge-v) 2007-01-09 12:51:03.000-0600

tristan: we need that updated patch. 1.4 has been branched off and the time to get new features in is now ...

By: Tristan Mahe (tristan_mahe) 2007-01-10 04:19:06.000-0600

patch added for rev. 50345

It compiles without complaining.

By: Emmanuel BUU (neutrino88) 2007-01-28 11:52:48.000-0600

Great feature. This was definitly missing.

By: Tristan Mahe (tristan_mahe) 2007-05-09 06:03:02

any feedback on usage of this patch ?

By: Jason Parker (jparker) 2007-07-05 17:07:09

Added to svn trunk in revision 73549.