Summary:ASTERISK-07274: [patch] Static Queue member 'pause' status is not stored with persistentmembers=yes
Reporter:dillec (dillec)Labels:
Date Opened:2006-07-03 03:59:03Date Closed:2011-06-07 14:08:24
Versions:Frequency of
Environment:Attachments:( 0) app_queue.c-0007471-persist-paused-static-queue-member-review.patch
Description:while only dynamic members are stored in astdb on reload, static members will loose their "pause" status on a restart of asterisk.


I'm working on a patch for that.
Comments:By: Serge Vecher (serge-v) 2006-07-05 09:53:39

diLLec: if you find a bug and working on the patch, please hold of on opening the report until you have the patch complete. Thanks for you contributions!

By: dillec (dillec) 2006-07-06 12:14:31

OK. here is the patch i've promised. It's tested and working for current trunk.

By: Serge Vecher (serge-v) 2006-07-06 12:17:35

1. Since you are only using type for if statement, the variable is not necessary. Just move strtol(type_tok, NULL, 10) inside if statement.
+ type = strtol(type_tok, NULL, 10);
+ if (type == 1) {
2. Curly bracket needs to stay with else here:
+ else
+ {
->+ else {

By: Serge Vecher (serge-v) 2006-07-06 12:18:12

also, did you get the disclaimer on file?

By: dillec (dillec) 2006-07-06 14:22:02

good to know that someone helps keeping the code clean. :-)
reviewed patch uploaded.

By: dillec (dillec) 2006-07-06 14:25:39

I can't change the disclaimer thingie now. Do i need to sign a document and send it to you, or can i give my acknowledgement by typing this note here ?

I'm idling also in #asterisk-bugs, #asterisk-dev or #asterisk in IRC. Feel free to contact me :-)

By: Serge Vecher (serge-v) 2006-07-06 14:33:42

well, a signed disclaimer form (one of the versions) needs to be signed and faxed or mailed back to Digium (or scanned version sent to kpfleming At digium D0T com). Once you do that, just type a quick note here that you've sent the disclaimer.

P.S. the patch looks ok now.

By: Serge Vecher (serge-v) 2006-07-07 11:42:02

for reference, from IRC conversations, diLLec is getting some testers to try this patch on their systems and report on workability

By: Tilmann Grossmann (terraner) 2006-07-18 15:51:21

i've tested the patch with the latest trunk. The patch is working and the problem is fixed by that.

By: jmls (jmls) 2006-10-31 14:12:45.000-0600

can this patch be applied to 1.2, 1.4 and trunk ?

By: dillec (dillec) 2006-11-01 07:19:00.000-0600

no that patch is otudated for now. i will post a new one as soon i'm able to.

By: jmls (jmls) 2007-01-01 12:52:14.000-0600

were you able to get round to this ? Thanks.

By: Serge Vecher (serge-v) 2007-03-13 10:07:53

ping diLLec

By: jmls (jmls) 2007-07-19 01:10:11

yikes. big ping ... were yoy able to do this patch

By: Jason Parker (jparker) 2007-08-20 11:21:08

Closing.  No response in about 8 months...

Please reopen if you get some time for this.