[Home]

Summary:ASTERISK-07271: [Patch] JabberStatus does not work if a resource is passed
Reporter:jmls (jmls)Labels:
Date Opened:2006-07-02 03:02:48Date Closed:2006-07-05 15:29:07
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Resources/res_jabber
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) res_jabber.patch
Description:There are two problems with JabberStatus

1) If a resource is passed as part of the Screenname parameter (abc@zyx.com/test) then the screenname is set to null

2) The program uses iterator->User to check against the screen name. However, the buddy->user field is not set in aji_create_buddy, only the buddy->name field so the test never works

****** ADDITIONAL INFORMATION ******

This patch fixes the two problems above, but also simplifies the aji_status_exec function by using

ASTOBJ_CONTAINER_FIND(&client->buddies, screenname);

and

aji_find_resource(buddy, resource);

instead of traversing the buddies and resources manually. I've also been able to remove a couple of variables as well.

I am not a C programmer, so would welcome comments on coding style (I've tried to follow the coding guidelines as much as possible) and functionality




Comments:By: Matt O'Gorman (mogorman) 2006-07-05 15:29:07

Committed revision 37087.