Summary:	ASTERISK-07170: [patch][post-1.4] External Password Notification (Instead of Replacing Default)
Reporter:	Philipp Dunkel (pdunkel)	Labels:
Date Opened:	2006-06-14 14:43:44	Date Closed:	2006-11-17 15:52:16.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) 7361-trunk-r47783.diff ( 1) 7361-trunk-r47803.diff ( 2) app_voicemail.diff
Description:	voicemail.conf contains a directive externpass which enables the calling of an external command when a user changes their password. However when this happens this is reflected neither in the system (ie no effect) nor in the voicemail.conf This patch adds an externpassnotify directive to voicemail.conf which like externpass calls an external command if the password is changed but only after the default behaviour (Internal Change and Change of voicemail.conf) has taken place. This is quite useful, because it enables the use of the default behaviour and also notifying any tools used to generate the config files of the change. ****** ADDITIONAL INFORMATION ****** I have an environment where I generate the asterisk configs from an XML-File. I don't want to use RealTime because of the overhead and the limitations. This way I just generate the standard config files. This enables me to react to changes in the running system without sacrificing the standard behaviour.
Comments:	By: Philipp Dunkel (pdunkel) 2006-06-14 14:46:15 Sorry broken connection. Same as 0007360 By: Serge Vecher (serge-v) 2006-06-16 11:47:46 marking this for consideration after 1.4-beta is worked from the trunk in upcoming weeks. By: Dov Bigio (dovb) 2006-07-31 12:33:47 Isn't this what externpass should do? Isn't it a bug in externpass? I really don't get the difference between the expected behavior of "externpass" and this proposed "externpassnotify"... By: Philipp Dunkel (pdunkel) 2006-08-01 06:55:25 externpass is used to do the entire password handling externally. It should not take any action other than calling the external program. externpassnotify is a middle ground between "external only" and "internal only" I don't thinkn the current implementation is buggy. I think it works as specified, except that I don't think the spec is all that is needed. By: Dov Bigio (dovb) 2006-08-01 09:03:19 So with externpass, not even voicemail.conf is updated... now I got it. Yes, totally agree this is not a buggy implementation, but would be a very useful enhancement! By: jmls (jmls) 2006-10-31 14:09:55.000-0600 this patch still applies to trunk (albeit with fuzz). By: Jason Parker (jparker) 2006-11-17 13:25:17.000-0600 New (different) patch uploaded for review.  I like this method better, since it's a bit more dynamic, and doesn't require a second struct and a second function.  With this change, one could technically add a "nopwchanges" option..or something. By: Philipp Dunkel (pdunkel) 2006-11-17 14:43:07.000-0600 @qwell: You are right, that is better. Even better would be to only have one variable that is a bitmask 0x01 = Internal 0x02 = External 0x04 = Something in the Future Any Methods that are set are applied :) P.S.: I fu..ed around with this so I actually have a patch against 47803 for this. If you want it I'll upload otherwise just go with yours. Greetings, Phil By: Philipp Dunkel (pdunkel) 2006-11-17 15:39:58.000-0600 Uploaded final patch. Which applies against SVN/Trunk cleanly and has been tested against all three cases Internal only External only Internal & External By: Jason Parker (jparker) 2006-11-17 15:52:15.000-0600 Committed to svn trunk in revision 47814, thanks!