| Summary: | ASTERISK-07153: [patch] res_osp: remove unneeded error messages | ||
| Reporter: | Andrey S Pankov (casper) | Labels: | |
| Date Opened: | 2006-06-12 17:29:51 | Date Closed: | 2006-06-15 07:27:28 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) res_osp.c.r33725.diff | |
| Description: | There is no need to output errors on ast_calloc failures. | ||
| Comments: | By: Tilghman Lesher (tilghman) 2006-06-13 22:03:56 Nonsense. There is always a need to report out of memory conditions, when possible. By: Andrey S Pankov (casper) 2006-06-15 05:51:04 Oh yeah... now I reopen the issue to show that you are 100% wrong here. Please open include/asterisk/utils.h file at line 310 and read _carefully_ description above and the code below. "Memory conditions" are already handled there in a pretty standard way. Even if built with MALLOC_DEBUG memory allocation failures are reported as well. Another thing here is that _current_ coding practice is not to report "out of memory" when using ast_(m|c|re)alloc. And I hope you'll review your opinion as to ASTERISK-7287342 "won't fix"... By: Tilghman Lesher (tilghman) 2006-06-15 07:27:28 Fixed in revision 34240. | ||