Summary:ASTERISK-07106: [patch] Asterisk sends INVITE instead of BYE if canreinvite=yes
Reporter:maik (maik)Labels:
Date Opened:2006-06-06 10:26:14Date Closed:2006-09-01 12:38:17
Versions:Frequency of
Environment:Attachments:( 0) branch-1.2-reinvite.1.patch
( 1) branch-1.2-reinvite.2.patch
( 2) sip_debug3.txt
( 3) trunk-reinvite.1.patch
Description:I used two snom phones for testing this. I configured them as user "1" and "2" in Asterisk:


In the attached sip debug user 1 calls 2. 2 answers and hangs up again after a few seconds. As you can see Asterisk sends an INVITE instead of BYE to user 1 and the phone doesn't hang up.

Rev 30069 seems to be the first that has this problem.
Comments:By: Serge Vecher (serge-v) 2006-06-06 10:47:12

maik: I believe this was fixed in 30098. Please feel free if this problem still exists in 1.2.9. Thanks.

By: Tilghman Lesher (tilghman) 2006-06-06 10:55:46

Reopened by request of reporter.

By: maik (maik) 2006-06-06 10:57:23


The problem still exists in 1.2.9. Sorry for not mentioning that (didn't get enough sleep :) ).

By: Olle Johansson (oej) 2006-06-06 15:54:09

the attached file is garbled. please upload new file with debug and verbose set to 4. thanks.

By: maik (maik) 2006-06-07 09:23:45


By: Serge Vecher (serge-v) 2006-06-07 09:52:07

maik: I don't see the 'debug' log in the file that you've posted. By default it is actually disabled. Can you please make sure you have the following line in your logger.conf:
console => notice,warning,error,debug

By: maik (maik) 2006-06-07 10:05:39

OK. I uploaded a new version with the debug log

By: phsultan (phsultan) 2006-06-08 08:06:49

Reproduced here too with a Cisco router and phone. Attached a simple fix applied to the trunk revision (disclaimer sent).

By: Serge Vecher (serge-v) 2006-06-08 09:21:18

sorry, I'm a little trigger-happy this morning ...

By: Olle Johansson (oej) 2006-06-08 13:13:46

Resolved in svn trunk 33069.

By: Olle Johansson (oej) 2006-06-08 13:14:06

Merci, Philippe!

By: maik (maik) 2006-06-08 13:38:39

The bug has not been fixed in the 1.2-branch so the status should probably be 'pending release branch' instead of 'closed'. ;)

Unfortunately the patch does not work for 1.2. :(

By: Leif Madsen (lmadsen) 2006-06-08 14:24:49

vechers says that kpfleming would prefer we not use "pending release branch" at this time... my bad! :)

By: Olle Johansson (oej) 2006-06-08 14:26:15

Sorry, missed that it exists in the release branch. Will fix.

By: Leif Madsen (lmadsen) 2006-06-08 15:16:09

Status: Assigned probably makes the most sense since oej said he'll fix -- thanks oej!

By: phsultan (phsultan) 2006-06-09 08:55:45

new patch based on trunk code applies to branch 1.2.

Hälsningar, soccer world cup is coming!

By: maik (maik) 2006-06-09 10:02:17

This patch fixes the problem.


By: Olle Johansson (oej) 2006-06-12 15:16:18

THats quite a big patch. Can we simplify it?

By: phsultan (phsultan) 2006-06-13 06:55:26

Sure, new version (branch-1.2-reinvite.2.patch) just checks that 'codecs' is not zero, without the other stuff taken from svn trunk. I tested it, maybe maik can confirm its validity too.

By: maik (maik) 2006-06-13 07:18:55

The new version works too.

By: Olle Johansson (oej) 2006-06-15 09:13:24

Committed to svn 1.2, rev 34306. Thanks, Philippe!

By: Kevin P. Fleming (kpfleming) 2006-09-01 12:38:17

The fix that was committed for this bug caused other problems for people, since it caused partial re-invites to be sent. I have committed the larger 1.2 patch that was proposed, since there was no particular reason to avoid it in the first place, it was clearly a better solution. The patch was committed in revision 41716 of branch-1.2.