|Summary:||ASTERISK-07103: [patch] [post 1.4] No AMI event sent on dialplan variable changes through AGI|
|Reporter:||Tony Howat (tonyh)||Labels:|
|Date Opened:||2006-06-06 07:09:40||Date Closed:||2007-07-11 19:59:23|
|Environment:||Attachments:||( 0) pbx.c.varset_uniqueid.patch|
( 1) pbx.diff
|Description:||Dialplan variable changes aren't passed to AMI events, unless you monitor NewExten - which isn't called at all if you're doing the changes via an AGI app.|
Propose a new VarSet event to indicate these changes - this allows my monitoring app (AMI events) to pick up data from my AGI based application through setting dialplan variables.
****** ADDITIONAL INFORMATION ******
pbx.c function pbx_builtin_setvar_helper, first line after variable defs :
manager_event(EVENT_FLAG_CALL, "VarSet", "Channel: %s\r\nVariable: %s\r\nValue: %s\r\n", chan ? chan->name : "(null)", name, value);
|Comments:||By: Serge Vecher (serge-v) 2006-06-12 19:08:41|
1. You need to have a disclaimer on file for this change to be considered.
2. Upload the change as a patch file agaist recent trunk
3. Please solicit feedback on Asterisk-dev list.
By: Tony Howat (tonyh) 2006-07-06 06:23:33
New pbx.diff uploaded based on 220.127.116.11.
I should now have disclaimer on file, was faxed earlier this week.
I will mail asterisk-devs for consultation today.
By: Serge Vecher (serge-v) 2006-07-06 08:58:06
tony: just a minor issue with the patch -> as per CODING GUIDELINES, only tabs are used for indentation, not spaces. Thanks.
By: Serge Vecher (serge-v) 2006-07-06 08:59:30
also, since this is a new feature, the change needs to be against svn trunk, not a release version, such as 18.104.22.168
By: Jonathan Towne (jontow) 2006-07-06 12:45:19
This patch applies (almost) cleanly to trunk. There is a bit of fuzz, but as-is it works great (no modifications to the patch).
I've tested it and it will be in use in my system regardless of whether it is committed to trunk or not.
Thank you, tonyh -- excellent work!
By: Jonathan Towne (jontow) 2006-07-06 14:08:54
The file I just uploaded ('pbx.c.varset_uniqueid.patch') is now against SVN trunk, and adds one more feature that we thought would be highly useful to track this event: the Uniqueid: field.
Please test and flame as necessary.
By: Serge Vecher (serge-v) 2006-07-06 14:38:13
ok, fine, I'll fix the spaces->tabs myself ;)
By: Jonathan Towne (jontow) 2006-07-06 20:18:07
woops, meant to correct that before I submitted; sorry vechers!
By: Serge Vecher (serge-v) 2006-07-07 08:39:43
jontow: can you please confirm that you have a disclaimer on file (I remember from other bugs that you do, but it is the policy to report your disclaimer status whenever you contribute code in somebody else's bug. BTW, mine is on file, even though I only changed spaces to tabs ;)
By: Jonathan Towne (jontow) 2006-07-07 12:35:07
vechers: Confirmed, I do have a disclaimer on file.
By: Joshua C. Colp (jcolp) 2006-07-07 13:43:48
So here is the scoop - I've assigned this to me and once we get a 1.4 beta out there and trunk returns to normal, we can put this in. I feel that by putting it in now we'll sort of be breaking our only "bug fix only" rule. This is such a small patch though that it won't take long to put it in once the time is right :)
By: jmls (jmls) 2006-10-31 12:32:24.000-0600
file: regarding the scoop - can this be put into trunk now ?
By: Serge Vecher (serge-v) 2006-12-07 14:26:36.000-0600
By: Russell Bryant (russell) 2007-06-08 11:13:52
This patch has been added to trunk in revision 68473. Thanks!